From d5f497b889794161facc1522d86720b587d1c0b7 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 18 Mar 2022 10:47:23 +0300 Subject: ptp: ocp: use snprintf() in ptp_ocp_verify() This code is fine, but it's easier to review if we use snprintf() instead of sprintf(). Signed-off-by: Dan Carpenter Acked-by: Jonathan Lemon Link: https://lore.kernel.org/r/20220318074723.GA6617@kili Signed-off-by: Jakub Kicinski --- drivers/ptp/ptp_ocp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'drivers/ptp/ptp_ocp.c') diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index d64a1ce5f5bc..c3d0fcf609e3 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -972,7 +972,7 @@ ptp_ocp_verify(struct ptp_clock_info *ptp_info, unsigned pin, switch (func) { case PTP_PF_NONE: - sprintf(buf, "IN: None"); + snprintf(buf, sizeof(buf), "IN: None"); break; case PTP_PF_EXTTS: /* Allow timestamps, but require sysfs configuration. */ @@ -982,9 +982,9 @@ ptp_ocp_verify(struct ptp_clock_info *ptp_info, unsigned pin, * channels 1..4 are the frequency generators. */ if (chan) - sprintf(buf, "OUT: GEN%d", chan); + snprintf(buf, sizeof(buf), "OUT: GEN%d", chan); else - sprintf(buf, "OUT: PHC"); + snprintf(buf, sizeof(buf), "OUT: PHC"); break; default: return -EOPNOTSUPP; -- cgit v1.2.3-59-g8ed1b