From 132c1e74aa7f8f9d33552645d2c35d3d8f9f0cf1 Mon Sep 17 00:00:00 2001 From: Harald Freudenberger Date: Wed, 20 Oct 2021 16:14:11 +0200 Subject: s390/ap: function rework based on compiler warning Slight rework of function __ap_revise_reserved() because of unused variable warning when build with W=1. This patch introduces an additional debug feature warning message when device_reprobe() returns with failure. However, the return value of __ap_revise_reserved() is still hard coded to 0 as this is a callback function to be used together with bus_for_each_dev() and thus the return value indicates to go on with the bus_for_each_dev() loop and not apport on a failure of something within this function. Signed-off-by: Harald Freudenberger Signed-off-by: Vasily Gorbik --- drivers/s390/crypto/ap_bus.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'drivers/s390/crypto') diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c index 806d184482a9..1986243f9cd3 100644 --- a/drivers/s390/crypto/ap_bus.c +++ b/drivers/s390/crypto/ap_bus.c @@ -793,6 +793,9 @@ static int __ap_revise_reserved(struct device *dev, void *dummy) AP_DBF_DBG("%s reprobing queue=%02x.%04x\n", __func__, card, queue); rc = device_reprobe(dev); + if (rc) + AP_DBF_WARN("%s reprobing queue=%02x.%04x failed\n", + __func__, card, queue); } } -- cgit v1.2.3-59-g8ed1b