From 54dcf0ceb8a21a898cd436617483e5646f2edcc6 Mon Sep 17 00:00:00 2001 From: Rasmus Villemoes Date: Thu, 19 Jun 2014 14:31:52 +0200 Subject: drivers/sbus/char: Micro-optimization in display7seg.c Flipping a bit doesn't need four lines of code; and gcc seems to actually generate two branches. Signed-off-by: Rasmus Villemoes Signed-off-by: David S. Miller --- drivers/sbus/char/display7seg.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'drivers') diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index b48899ce8506..2b0ce7c350ee 100644 --- a/drivers/sbus/char/display7seg.c +++ b/drivers/sbus/char/display7seg.c @@ -144,10 +144,7 @@ static long d7s_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case D7SIOCTM: /* toggle device mode-- flip display orientation */ - if (regs & D7S_FLIP) - regs &= ~D7S_FLIP; - else - regs |= D7S_FLIP; + regs ^= D7S_FLIP; writeb(regs, p->regs); break; } -- cgit v1.2.3-59-g8ed1b