From 9ccfc23a72b669678e4c9ccba98d3d91db1c04cf Mon Sep 17 00:00:00 2001 From: Steve French Date: Mon, 23 May 2022 20:54:04 -0500 Subject: smb3: don't set rc when used and unneeded in query_info_compound rc is not checked so should not be set coming back from open_cached_dir (the cfid pointer is checked instead to see if open_cached_dir failed) Addresses-Coverity: 1518021 ("Code maintainability issues (UNUSED_VALUE)") Reviewed-by: Ronnie Sahlberg Signed-off-by: Steve French --- fs/cifs/smb2ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/cifs') diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 0d7feb9e609e..ed2f8a69658d 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2700,7 +2700,7 @@ smb2_query_info_compound(const unsigned int xid, struct cifs_tcon *tcon, memset(rsp_iov, 0, sizeof(rsp_iov)); if (!strcmp(path, "")) - rc = open_cached_dir(xid, tcon, path, cifs_sb, &cfid); + open_cached_dir(xid, tcon, path, cifs_sb, &cfid); /* cfid null if open dir failed */ memset(&open_iov, 0, sizeof(open_iov)); rqst[0].rq_iov = open_iov; -- cgit v1.2.3-59-g8ed1b