From 6a628fa43810f861da50c593c69f2ead1c829231 Mon Sep 17 00:00:00 2001 From: Alexander Aring Date: Fri, 12 Nov 2021 10:08:01 -0500 Subject: fs: dlm: fix potential buffer overflow This patch fixes an potential overflow in sscanf and the maximum declared string parsing length which seems to be excluding the null termination symbol. This patch will just add one byte to be prepared on a string with length of DLM_RESNAME_MAXLEN including the null termination symbol. Fixes: 5054e79de999 ("fs: dlm: add lkb debugfs functionality") Reported-by: kernel test robot Signed-off-by: Alexander Aring Signed-off-by: David Teigland --- fs/dlm/debug_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/dlm/debug_fs.c') diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index df6f3f107be4..8fb04ebbafb5 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c @@ -640,7 +640,7 @@ static ssize_t table_write2(struct file *file, const char __user *user_buf, { struct seq_file *seq = file->private_data; int n, len, lkb_nodeid, lkb_status, error; - char name[DLM_RESNAME_MAXLEN] = {}; + char name[DLM_RESNAME_MAXLEN + 1] = {}; struct dlm_ls *ls = seq->private; unsigned int lkb_flags; char buf[256] = {}; -- cgit v1.2.3-59-g8ed1b