From a2e3965df40af2f48ee6c97ed573adb91ced5dac Mon Sep 17 00:00:00 2001 From: xu xin Date: Tue, 28 Dec 2021 07:32:52 +0000 Subject: ext4: use BUG_ON instead of if condition followed by BUG BUG_ON would be better. This issue was detected with the help of Coccinelle. Reported-by: Zeal robot Reviewed-by: Lukas Czerner Signed-off-by: xu xin Link: https://lore.kernel.org/r/20211228073252.580296-1-xu.xin16@zte.com.cn Signed-off-by: Theodore Ts'o --- fs/ext4/ext4.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'fs/ext4') diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 88c240a9cc42..715ee206dfe1 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2400,8 +2400,7 @@ ext4_rec_len_from_disk(__le16 dlen, unsigned blocksize) static inline __le16 ext4_rec_len_to_disk(unsigned len, unsigned blocksize) { - if ((len > blocksize) || (blocksize > (1 << 18)) || (len & 3)) - BUG(); + BUG_ON((len > blocksize) || (blocksize > (1 << 18)) || (len & 3)); #if (PAGE_SIZE >= 65536) if (len < 65536) return cpu_to_le16(len); -- cgit v1.2.3-59-g8ed1b