From 8a5daf1e2c199746767d94b4036638ba11d528b3 Mon Sep 17 00:00:00 2001 From: Simon Derr Date: Tue, 11 Mar 2014 10:14:15 +0100 Subject: 9pnet_rdma: check token type before int conversion When parsing options, make sure we have found a proper token before doing a numeric conversion. Without this check, the current code will end up following random pointers that just happened to be on the stack when this function was called, because match_token() will not touch the 'args' list unless a valid token is found. Signed-off-by: Simon Derr Signed-off-by: Eric Van Hensbergen --- net/9p/trans_rdma.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'net/9p/trans_rdma.c') diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 8f5e4f769d13..14ad43b5cf89 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c @@ -193,6 +193,8 @@ static int parse_opts(char *params, struct p9_rdma_opts *opts) if (!*p) continue; token = match_token(p, tokens, args); + if (token == Opt_err) + continue; r = match_int(&args[0], &option); if (r < 0) { p9_debug(P9_DEBUG_ERROR, -- cgit v1.2.3-59-g8ed1b