From 6005a8aecee8afeba826295321a612ab485c230e Mon Sep 17 00:00:00 2001 From: Jiri Pirko Date: Thu, 25 Aug 2022 13:29:23 +0200 Subject: net: devlink: add RNLT lock assertion to devlink_compat_switch_id_get() Similar to devlink_compat_phys_port_name_get(), make sure that devlink_compat_switch_id_get() is called with RTNL lock held. Comment already says so, so put this in code as well. Signed-off-by: Jiri Pirko Link: https://lore.kernel.org/r/20220825112923.1359194-1-jiri@resnulli.us Signed-off-by: Jakub Kicinski --- net/core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'net/core/devlink.c') diff --git a/net/core/devlink.c b/net/core/devlink.c index 0f7078db1280..2afbeb6eca67 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -12505,6 +12505,8 @@ int devlink_compat_switch_id_get(struct net_device *dev, * devlink_port instance cannot disappear in the middle. No need to take * any devlink lock as only permanent values are accessed. */ + ASSERT_RTNL(); + devlink_port = netdev_to_devlink_port(dev); if (!devlink_port || !devlink_port->switch_port) return -EOPNOTSUPP; -- cgit v1.2.3-59-g8ed1b