From 3791b3f6fb74d265c93d493d9bbf29c1e769ceae Mon Sep 17 00:00:00 2001 From: Christoph Jaeger Date: Tue, 12 Aug 2014 09:27:57 +0200 Subject: openvswitch: Fix memory leak in ovs_vport_alloc() error path ovs_vport_alloc() bails out without freeing the memory 'vport' points to. Picked up by Coverity - CID 1230503. Fixes: 5cd667b0a4 ("openvswitch: Allow each vport to have an array of 'port_id's.") Signed-off-by: Christoph Jaeger Signed-off-by: David S. Miller --- net/openvswitch/vport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'net/openvswitch/vport.c') diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index 702fb21bfe15..6d8f2ec481d9 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -137,8 +137,10 @@ struct vport *ovs_vport_alloc(int priv_size, const struct vport_ops *ops, vport->ops = ops; INIT_HLIST_NODE(&vport->dp_hash_node); - if (ovs_vport_set_upcall_portids(vport, parms->upcall_portids)) + if (ovs_vport_set_upcall_portids(vport, parms->upcall_portids)) { + kfree(vport); return ERR_PTR(-EINVAL); + } vport->percpu_stats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats); if (!vport->percpu_stats) { -- cgit v1.2.3-59-g8ed1b