diff options
| author |   Shannon Nelson <shannon.nelson@amd.com> | 2024-02-23 14:27:41 -0800 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2024-02-27 13:03:32 +0100 |
| commit | 7662fad348ac54120e9e6443cb0bbe4f3b582219 (patch) | |
| tree | b1a1ad1ce2f10926527cdd90a4e1471123d2b601 /drivers/net/ethernet/pensando/ionic/ionic_main.c | |
| parent | ionic: check before releasing pci regions (diff) | |
| download | linux-rng-7662fad348ac54120e9e6443cb0bbe4f3b582219.tar.xz linux-rng-7662fad348ac54120e9e6443cb0bbe4f3b582219.zip | |
ionic: check cmd_regs before copying in or out
Since we now have potential cases of NULL cmd_regs and info_regs
during a reset recovery, and left NULL if a reset recovery has
failed, we need to check that they exist before we use them.
Most of the cases were covered in the original patch where we
verify before doing the ioreadb() for health or cmd status.
However, we need to protect a few uses of io mem that could
be hit in error recovery or asynchronous threads calls as well
(e.g. ethtool or devlink handlers).
Fixes: 219e183272b4 ("ionic: no fw read when PCI reset failed")
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c index 165ab08ad2dd..2f479de329fe 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c @@ -416,6 +416,9 @@ static void ionic_dev_cmd_clean(struct ionic *ionic) { struct ionic_dev *idev = &ionic->idev; + if (!idev->dev_cmd_regs) + return; + iowrite32(0, &idev->dev_cmd_regs->doorbell); memset_io(&idev->dev_cmd_regs->cmd, 0, sizeof(idev->dev_cmd_regs->cmd)); } |