diff options
| author |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-02 15:16:20 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-11 13:50:45 +0100 |
| commit | bf0fd01c7cc1061fb2cfda3e2044371642108e6c (patch) | |
| tree | 979bbf4764932c7d6aed2918be7b2ca5d0b968d8 | |
| parent | misc: vmw_balloon: fix memory leak with using debugfs_lookup() (diff) | |
| download | linux-stable-bf0fd01c7cc1061fb2cfda3e2044371642108e6c.tar.xz linux-stable-bf0fd01c7cc1061fb2cfda3e2044371642108e6c.zip | |
drivers: base: component: fix memory leak with using debugfs_lookup()
[ Upstream commit 8deb87b1e810dd558371e88ffd44339fbef27870 ]
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/20230202141621.2296458-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/base/component.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/component.c b/drivers/base/component.c index 5eadeac6c532..7dbf14a1d915 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -125,7 +125,7 @@ static void component_debugfs_add(struct aggregate_device *m) static void component_debugfs_del(struct aggregate_device *m) { - debugfs_remove(debugfs_lookup(dev_name(m->parent), component_debugfs_dir)); + debugfs_lookup_and_remove(dev_name(m->parent), component_debugfs_dir); } #else |