aboutsummaryrefslogtreecommitdiffstats
path: root/pygithub3/tests/services
diff options
context:
space:
mode:
authorDavid Medina <davidmedina9@gmail.com>2012-02-10 20:16:27 +0100
committerDavid Medina <davidmedina9@gmail.com>2012-02-10 20:16:27 +0100
commit2ce25481375904c9a0247e83ee3ef7b37ff53866 (patch)
tree9d05e5f557543b47637b7a7368511b7255cd640a /pygithub3/tests/services
parentWIP on resources.users tests (diff)
downloadpython-github3-2ce25481375904c9a0247e83ee3ef7b37ff53866.tar.xz
python-github3-2ce25481375904c9a0247e83ee3ef7b37ff53866.zip
Fix asserts bugs in client.
Fixing something that is there to check what never happens... But tests doesn't lie, so funny :P
Diffstat (limited to 'pygithub3/tests/services')
-rw-r--r--pygithub3/tests/services/test_core.py5
-rw-r--r--pygithub3/tests/services/test_users.py5
2 files changed, 6 insertions, 4 deletions
diff --git a/pygithub3/tests/services/test_core.py b/pygithub3/tests/services/test_core.py
index c52b044..cdfe176 100644
--- a/pygithub3/tests/services/test_core.py
+++ b/pygithub3/tests/services/test_core.py
@@ -8,7 +8,7 @@ import requests
from pygithub3.services.base import Base
from pygithub3.core.result import Result
-from pygithub3.tests.utils.base import DummyRequest
+from pygithub3.tests.utils.base import DummyRequest, mock_response
from .utils import _
@@ -32,16 +32,19 @@ class TestServiceCalls(TestCase):
data=data, params=self.args)
def test_DELETE(self, request_method):
+ request_method.return_value = mock_response(204)
self.s._delete(self.r, **self.args)
request_method.assert_called_with('delete', _('dummyrequest'),
data=None, params=self.args)
def test_POST(self, request_method):
+ request_method.return_value = mock_response(201)
self.s._post(self.r, **self.args)
request_method.assert_called_with('post', _('dummyrequest'),
data=None, params=self.args)
def test_GET(self, request_method):
+ request_method.return_value = mock_response()
self.s._get(self.r, **self.args)
request_method.assert_called_with('get', _('dummyrequest'),
params=self.args)
diff --git a/pygithub3/tests/services/test_users.py b/pygithub3/tests/services/test_users.py
index f2daa36..9c333ec 100644
--- a/pygithub3/tests/services/test_users.py
+++ b/pygithub3/tests/services/test_users.py
@@ -8,6 +8,7 @@ from mock import patch, Mock
from pygithub3.services.users import User
from pygithub3.resources.base import json
+from pygithub3.tests.utils.base import mock_response
from pygithub3.tests.utils.services import _, mock_json
json.dumps = Mock(side_effect=mock_json)
@@ -20,8 +21,6 @@ class TestUserService(TestCase):
self.us = User()
def test_GET_without_user(self, request_method):
- response = Mock(name='response')
- response.content = {'dummy': 'dummy'}
- request_method.return_value = response
+ request_method.return_value = mock_response()
self.us.get()
request_method.assert_called_with('get', _('user'), params={})