From 837c07729c089b8c5fdf3828cedff054b0cf1dde Mon Sep 17 00:00:00 2001 From: Alejandro Gómez Date: Fri, 27 Apr 2012 13:50:25 +0200 Subject: test Label validation errors --- pygithub3/tests/resources/test_issues.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 pygithub3/tests/resources/test_issues.py (limited to 'pygithub3/tests/resources') diff --git a/pygithub3/tests/resources/test_issues.py b/pygithub3/tests/resources/test_issues.py new file mode 100644 index 0000000..0bef3c1 --- /dev/null +++ b/pygithub3/tests/resources/test_issues.py @@ -0,0 +1,17 @@ +#!/usr/bin/env python +# -*- encoding: utf-8 -*- + +from unittest import TestCase + +from pygithub3.resources.issues import Label + + +class TestLabel(TestCase): + def test_is_valid_color(self): + valid_colors = ['BADA55', 'FFFFFF', '45DFCA'] + for color in valid_colors: + self.assertTrue(Label.is_valid_color(color)) + + invalid_colors = ['BDA55', '#FFAABB', 'FFf'] + for color in invalid_colors: + self.assertFalse(Label.is_valid_color(color)) -- cgit v1.2.3-59-g8ed1b From a83b53bbb807aa01b490ca56e186e69e4befc08c Mon Sep 17 00:00:00 2001 From: Alejandro Gómez Date: Thu, 17 May 2012 22:41:59 +0200 Subject: add Pull Request to `Issue` resources --- pygithub3/resources/issues.py | 14 ++++++++++++-- pygithub3/tests/resources/test_issues.py | 2 +- 2 files changed, 13 insertions(+), 3 deletions(-) (limited to 'pygithub3/tests/resources') diff --git a/pygithub3/resources/issues.py b/pygithub3/resources/issues.py index af7547f..69f905a 100644 --- a/pygithub3/resources/issues.py +++ b/pygithub3/resources/issues.py @@ -5,9 +5,11 @@ import re from .base import Resource from .users import User +from .pull_requests import PullRequest class Label(Resource): + @staticmethod def is_valid_color(color): valid_color = re.compile(r'[0-9abcdefABCDEF]{6}') @@ -21,6 +23,7 @@ class Label(Resource): class Milestone(Resource): + _dates = ('created_at', 'due_on') _maps = {'creator': User} @@ -30,8 +33,15 @@ class Milestone(Resource): class Issue(Resource): - _dates = ('created_at', 'updated_at') - _maps = {'assignee': User, 'user': User} + _dates = ('created_at', 'updated_at', 'closed_at') + _maps = { + 'assignee': User, + 'user': User, + 'milestone': Milestone, + 'pull_request': PullRequest + } + + _collection_maps = {'labels': Label} def __str__(self): return '' % getattr(self, 'number', '') diff --git a/pygithub3/tests/resources/test_issues.py b/pygithub3/tests/resources/test_issues.py index 0bef3c1..ae572af 100644 --- a/pygithub3/tests/resources/test_issues.py +++ b/pygithub3/tests/resources/test_issues.py @@ -8,7 +8,7 @@ from pygithub3.resources.issues import Label class TestLabel(TestCase): def test_is_valid_color(self): - valid_colors = ['BADA55', 'FFFFFF', '45DFCA'] + valid_colors = ['BADa55', 'FF42FF', '45DFCA'] for color in valid_colors: self.assertTrue(Label.is_valid_color(color)) -- cgit v1.2.3-59-g8ed1b