QEMU development tree https://git.zx2c4.com/qemu/atom/linux-user/i386?h=master 2024-05-26T22:49:58Z 2024-05-26T22:49:58Z Richard Henderson richard.henderson@linaro.org 2024-04-09T04:04:19Z urn:sha1:701890bdd09b289fd9cb852e714e91373088b0f3 We have already validated the memory region in the course of validating the signal frame. No need to do it again within the helper function. In addition, return failure when the header contains invalid xstate_bv. The kernel handles this via exception handling within XSTATE_OP within xrstor_from_user_sigframe. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T22:45:27Z Richard Henderson richard.henderson@linaro.org 2024-04-09T03:57:11Z urn:sha1:9c2fb9e1d589fbda266d8db611b9d3a38ab96a3c We have already validated the memory region in the course of validating the signal frame. No need to do it again within the helper function. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T22:45:27Z Richard Henderson richard.henderson@linaro.org 2024-04-09T03:31:05Z urn:sha1:76d8d0f85caf629b4df314e656d20ad6565bab9b We have already validated the memory region in the course of validating the signal frame. No need to do it again within the helper function. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T22:45:27Z Richard Henderson richard.henderson@linaro.org 2024-04-09T01:05:28Z urn:sha1:c6e6d1508ac309e39fec827c3719c86c10cd8975 Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T22:45:27Z Richard Henderson richard.henderson@linaro.org 2024-04-09T00:51:54Z urn:sha1:7973eb943e670ea66a19e04868e01803c7594246 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T22:45:23Z Richard Henderson richard.henderson@linaro.org 2024-04-09T00:30:30Z urn:sha1:a7365e984d27b961f381cf3be46682e4da5ab6f7 For modern cpus, the kernel uses xsave to store all extra cpu state across the signal handler. For xsave/xrstor to work, the pointer must be 64 byte aligned. Moreover, the regular part of the signal frame must be 16 byte aligned. Attempt to mirror the kernel code as much as possible. Use enum FPStateKind instead of use_xsave() and use_fxsr(). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1648 Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T19:51:50Z Richard Henderson richard.henderson@linaro.org 2024-04-08T23:15:03Z urn:sha1:9e9b7d4c15b1cbefc608487a38e10c8f708fb187 Invert the sense of the return value and use bool. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T19:51:50Z Richard Henderson richard.henderson@linaro.org 2024-04-08T23:07:54Z urn:sha1:c536f9b77ccb771fc480ec8d3c1cefac243eac73 Invert the sense of the return value and use bool. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T19:51:50Z Richard Henderson richard.henderson@linaro.org 2024-04-08T21:51:53Z urn:sha1:bae0455ce3ded1df80dee4e844194568063ad093 Since v2.6.19, the kernel has supported -mregparm=3. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> 2024-05-26T19:51:50Z Richard Henderson richard.henderson@linaro.org 2024-04-08T20:53:55Z urn:sha1:5cc77ebe9b9e07fcd06011dc23162069ef8c5eff Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>