From 267691b65cf7167881609dde1e50a4aafd86af08 Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Mon, 3 Jun 2019 14:50:46 +0800 Subject: migration: No need to take rcu during sync_dirty_bitmap cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as parameter, which means that it must be with RCU read lock held already. Taking it again inside seems redundant. Removing it. Instead comment on the functions about the RCU read lock. Reviewed-by: Paolo Bonzini Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Message-Id: <20190603065056.25211-2-peterx@redhat.com> Signed-off-by: Juan Quintela --- migration/ram.c | 1 + 1 file changed, 1 insertion(+) (limited to 'migration/ram.c') diff --git a/migration/ram.c b/migration/ram.c index 89eec7ee9d..48969db84b 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1674,6 +1674,7 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs, return ret; } +/* Called with RCU critical section */ static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb, ram_addr_t length) { -- cgit v1.2.3-59-g8ed1b