diff options
| author |   Frantisek Sumsal <frantisek@sumsal.cz> | 2024-01-04 16:48:10 +0100 |
|---|---|---|
| committer | Frantisek Sumsal <frantisek@sumsal.cz> | 2024-01-04 20:56:21 +0100 |
| commit | 5169f8cfd543cbce498871527ea8aa454ff2c252 (patch) | |
| tree | 8608bb6714706e9a1413973667662530f88d1ae6 | |
| parent | tmpfiles: add --purge switch (diff) | |
| download | systemd-5169f8cfd543cbce498871527ea8aa454ff2c252.tar.xz systemd-5169f8cfd543cbce498871527ea8aa454ff2c252.zip | |
resolve: initialize `r` during OOM
Otherwise we'd use some garbage value in the error path.
../src/resolve/resolved-dns-query.c: In function ‘dns_query_accept’:
../src/resolve/resolved-dns-query.c:944:27: error: ‘r’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
944 | q->answer_errno = -r;
| ^~
cc1: all warnings being treated as errors
Follow-up for 9ca133e97a0.
| -rw-r--r-- | src/resolve/resolved-dns-query.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/resolve/resolved-dns-query.c b/src/resolve/resolved-dns-query.c index d94fe1da997..a7bc45838f7 100644 --- a/src/resolve/resolved-dns-query.c +++ b/src/resolve/resolved-dns-query.c @@ -902,7 +902,7 @@ static void dns_query_accept(DnsQuery *q, DnsQueryCandidate *c) { if (t->answer_ede_msg) { answer_ede_msg = strdup(t->answer_ede_msg); if (!answer_ede_msg) { - log_oom(); + r = log_oom(); goto fail; } } |