aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Rozman <simon@rozman.si>2021-06-10 10:39:06 +0200
committerSimon Rozman <simon@rozman.si>2021-07-12 10:38:21 +0200
commitd41ac045655ba8149542b136cdc65be5e9945a54 (patch)
treecedbafdebc5a20b7fb2ee9910963975f035d2584
parentapi: use SuggestedInstanceId instead of NetSetupAnticipatedInstanceId (diff)
downloadwintun-d41ac045655ba8149542b136cdc65be5e9945a54.tar.xz
wintun-d41ac045655ba8149542b136cdc65be5e9945a54.zip
driver: remove excessive media connection reporting on adapter init
The initial adapter state (including media connection) is provided by the NDIS_MINIPORT_ADAPTER_GENERAL_ATTRIBUTES. Additional NdisMIndicateStatusEx() call seems excessive. Signed-off-by: Simon Rozman <simon@rozman.si>
-rw-r--r--driver/wintun.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/driver/wintun.c b/driver/wintun.c
index 68037cd..0b4bfe1 100644
--- a/driver/wintun.c
+++ b/driver/wintun.c
@@ -1098,6 +1098,7 @@ TunInitializeEx(
.RcvLinkSpeed = TUN_LINK_SPEED,
.XmitLinkSpeed = TUN_LINK_SPEED,
.MediaConnectState = MediaConnectStateDisconnected,
+ .MediaDuplexState = MediaDuplexStateFull,
.LookaheadSize = TUN_MAX_IP_PACKET_SIZE,
.MacOptions =
NDIS_MAC_OPTION_TRANSFERS_NOT_PEND | NDIS_MAC_OPTION_COPY_LOOKAHEAD_DATA | NDIS_MAC_OPTION_NO_LOOPBACK,
@@ -1123,10 +1124,6 @@ TunInitializeEx(
MiniportAdapterHandle, (PNDIS_MINIPORT_ADAPTER_ATTRIBUTES)&AdapterGeneralAttributes)))
goto cleanupFreeNblPool;
- /* A miniport driver can call NdisMIndicateStatusEx after setting its
- * registration attributes even if the driver is still in the context
- * of the MiniportInitializeEx function. */
- TunIndicateStatus(Ctx->MiniportAdapterHandle, MediaConnectStateDisconnected);
return NDIS_STATUS_SUCCESS;
cleanupFreeNblPool: