aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* api: log out-of-memory errors tooSimon Rozman2020-10-303-36/+24
| | | | | | | It's not likely the write to log will succeed in low memory condition thou. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: remove dead codeSimon Rozman2020-10-302-14/+0
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: added missing allocation-failure checkSimon Rozman2020-10-301-0/+2
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: stop double error status reportingSimon Rozman2020-10-305-46/+46
| | | | | | | When an internal function logs an error and its cause, it bloats the log when the caller logs the cause again. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: internal reorganizationSimon Rozman2020-10-3012-444/+424
| | | | | | | | | | | Gather adapter management in adapter.h/.c (formerly devmgmt.h/.c) and unify HwID tests. Use "Namespace" namespace in all functions from namespace.h/.c. Fix char strings in LOG_... Signed-off-by: Simon Rozman <simon@rozman.si>
* api: simplify logger macros namesSimon Rozman2020-10-306-143/+143
| | | | | | | | | | | WINTUN_LOGGER_... => LOGGER_... => LOG_... Those macros are internal, so they don/t need to start with WINTUN_... Replacing the noun LOGGER_... with the verb LOG_... makes the code more natural to read now. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: implement driver version extraction from .inf fileSimon Rozman2020-10-302-23/+175
| | | | | | | | | | | | | With installer.dll the installer did the decision whether to install or upgrade the driver according to installer.dll version and hash stored in registry by MSM. With wintun.dll we need to know, which version of Wintun driver we are packing in the resources to decide about driver upgrade. The most accurate source of the driver version is the DriverVer directive in [Version] section of the driver's .inf file. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: disable driver management for wintun.dll that don't have a driverSimon Rozman2020-10-302-96/+102
| | | | | | | Namely the 32-bit ARM platform, which we will ship wintun.dll for ARM on ARM64 clients exclusively. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: unify and document resource loadingSimon Rozman2020-10-303-30/+54
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: unify hardware ID stringSimon Rozman2020-10-303-10/+6
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: unify callback function type namesSimon Rozman2020-10-302-3/+3
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: add driver managementSimon Rozman2020-10-309-15/+676
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: introduce loggingSimon Rozman2020-10-3012-217/+502
| | | | | | And other unifications with installer before merging. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: split api.hSimon Rozman2020-10-308-116/+172
| | | | | | As the project grew, api.h got bloated. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: revise str/memcpySimon Rozman2020-10-301-3/+3
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: make adapter name searching more efficientSimon Rozman2020-10-301-4/+7
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: honor locale when comparing case-insensitiveSimon Rozman2020-10-304-3/+26
| | | | | | | | | Quote from MSDN: > You will need to call setlocale for _wcsicmp to work with Latin 1 > characters. The C locale is in effect by default, so, for example, ä > will not compare equal to Ä. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: fix trailing number detection in RemoveNumberedSuffix()Simon Rozman2020-10-301-1/+1
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: add support for WoW64Simon Rozman2020-10-309-12/+130
| | | | | | | | Some functions of SetupAPI only work when invoked from a native process. Registry and filesystem reflection makes them fail on WoW64. For WoW64 processes, a minimum set of rundll32 functions are provided. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: tighten source code annotationSimon Rozman2020-10-302-4/+7
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: update documentationSimon Rozman2020-10-303-99/+106
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: simplify workflowSimon Rozman2020-10-301-54/+32
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: revise and unify error codesSimon Rozman2020-10-301-7/+7
| | | | | | | | | | | | | | | GetDevInfoData: Some functions returned ERROR_OBJECT_NOT_FOUND, others ERROR_FILE_NOT_FOUND when the needle was not found in the haystack. GetTcpipInterfaceRegPath: When IpConfig is an empty REG_MULTI_SZ, it is actually ERROR_INVALID_DATA - like other unexpected registry values - rather than a misleading ERROR_NETWORK_NOT_AVAILABLE. Failure in TakeNameMutex result in ERROR_INVALID_HANDLE rather than the ERROR_GEN_FAILURE with a misleading message: "A device attached to the system is not functioning." Signed-off-by: Simon Rozman <simon@rozman.si>
* api: tighten maximum registry key path lengthSimon Rozman2020-10-303-15/+19
| | | | | | | Maximum registry key path length is not 260 (MAX_PATH), but 255 (256 incl. zero terminator). Signed-off-by: Simon Rozman <simon@rozman.si>
* api: fix SPDRP_DEVICEDESC zero-terminationSimon Rozman2020-10-301-1/+1
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: do the set-quiet-install laterSimon Rozman2020-10-301-8/+4
| | | | | | | Rather than setting the "quiet" flag to each and every device in the process of iterating, set it when actually creating/deleting it. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: cleanupSimon Rozman2020-10-306-280/+293
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: add pre-compiled header supportSimon Rozman2020-10-309-14/+40
| | | | | | ...for super-fast compilation. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: rename WINSTATUS to WINTUN_STATUSSimon Rozman2020-10-305-52/+52
| | | | | | ...to reduce name collision probability. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: finish porting from wireguard-goSimon Rozman2020-10-306-285/+1293
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: unify Win32 error typeSimon Rozman2020-10-303-32/+40
| | | | | | | This makes the code more readable and works around the clang-format.exe issues with _Return_type_success_ source annotation. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: port GetInterface member from wireguard-goSimon Rozman2020-10-305-1/+776
| | | | | | | | | | | Mind that this also fixes the order of adapter detection checks. A fast test to eliminate non-Wintun adapters from iteration to speed things up rendered the method incapable of detecting a non-Wintun adapter with the name we are looking for. ERROR_OBJECT_NOT_FOUND was replaced with ERROR_FILE_NOT_FOUND. Signed-off-by: Simon Rozman <simon@rozman.si>
* api: port nci package from wireguard-goSimon Rozman2020-10-305-0/+54
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: port tun\wintun\namespace_windows.go from wireguard-goSimon Rozman2020-10-305-2/+222
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* api: add skeleton for wintun.dllSimon Rozman2020-10-309-5/+316
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* msi-example: add ARM64 supportSimon Rozman2020-10-303-10/+22
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* msi-example: remove unused parameter in call :msiSimon Rozman2020-10-301-3/+3
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* Enable ARM64 MSM buildingSimon Rozman2020-10-301-2/+2
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* installer: ignore light.exe internal errorSimon Rozman2020-10-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wix Toolset introduced an issue beginning with the v3.14.0.3827 release. When linking merge module, the light.exe displays an internal error: ``` WixLink: "C:\Program Files (x86)\WiX Toolset v3.14\bin\light.exe" -nologo -b o utput_dir="..\amd64\Release" -spdb -sw1076 -sw1079 -out "..\dist\wintu n-amd64-0.8.msm" "..\amd64\Release\installer-intermediate\installer.wi xobj" light.exe : error LGHT0204: ICEM10: The property 'ProductCode' is not al lowed in a Merge Module [C:\Users\Simon\Projekti\wintun\installer\instal ler.vcxproj] C:\Users\Simon\AppData\Local\Temp\xdyw3dnt\wintun-amd64-0.8.msm : error LGHT0204: ICE03: Table: Component Column: _IceM05Mark Missing specificat ions in _Validation Table (or Old Database) [C:\Users\Simon\Projekti\win tun\installer\installer.vcxproj] C:\Users\Simon\AppData\Local\Temp\xdyw3dnt\wintun-amd64-0.8.msm : error LGHT0204: ICE03: Table: File Column: _ICEM07CAB Missing specifications i n _Validation Table (or Old Database) [C:\Users\Simon\Projekti\wintun\in staller\installer.vcxproj] light.exe : error LGHT0217: Error executing ICE action 'ICE103'. The mos t common cause of this kind of ICE failure is an incorrectly registered scripting engine. See http://wixtoolset.org/documentation/error217/ for details and how to solve this problem. The following string format was n ot expected by the external UI message logger: "There is a problem with this Windows Installer package. A DLL required for this install to compl ete could not be run. Contact your support personnel or package vendor. ". [C:\Users\Simon\Projekti\wintun\installer\installer.vcxproj] The command ""C:\Program Files (x86)\WiX Toolset v3.14\bin\light.exe" -nologo -b output_dir="..\amd64\Release" -spdb -sw1076 -sw1079 -out " ..\dist\wintun-amd64-0.8.msm" "..\amd64\Release\installer-intermediate \installer.wixobj"" exited with code 217. ``` This error is not a direct consequence of anything being wrong in our source code. Fortunately, the utility still produces identical MSM file as previous WiX Toolset versions do. Unfortunately, it exits with code 217. However, we need recent v3.14 for ARM64 support. I know this is a huge issue for our build system, masking out any other potential true error, but the light.exe exit code has been temporarily ignored. Signed-off-by: Simon Rozman <simon@rozman.si>
* installer: ARM64 requires msiexec version >=500Simon Rozman2020-10-302-2/+6
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* Accept WoW64 clientsSimon Rozman2020-10-301-10/+47
| | | | Signed-off-by: Simon Rozman <simon@rozman.si>
* installer: ARM64 is always Windows 10Simon Rozman2020-10-303-1/+11
| | | | | | | | | | | | | | ARM64 support was introduced in Windows 10. There is no need to pack the EV signed ARM64 driver for older Windows releases. The only use-case we do want to pack an EV signed ARM64 driver (or test signed) in the installer.dll is when we are doing the rundll32.exe tests. Therefore, the Debug version still packs it. If there is no driver available to pack, fail at compile time - rather than build an installer.dll that would fail at runtime. Signed-off-by: Simon Rozman <simon@rozman.si>
* Use standard volatile semanticsShawn Hoffman2020-10-304-98/+40
| | | | | | | | Make all archs are use the standardized concept of volatile. This patch will cause the most changes to arm64 codegen. Signed-off-by: Shawn Hoffman <godisgovernment@gmail.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Fix potential TunDispatchSecurityDescriptor leakJason A. Donenfeld2020-10-301-0/+3
| | | | | | | | TunDispatchSecurityDescriptor will leak if RtlAbsoluteToSelfRelativeSD fails. Add cleanup in error path. Reported-by: Shawn Hoffman <godisgovernment@gmail.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Use RtlSubAuthoritySid instead of directly poking SIDShawn Hoffman2020-10-301-1/+1
| | | | | Signed-off-by: Shawn Hoffman <godisgovernment@gmail.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Reschedule EvaluateWintun between InstallInitialize and InstallFinalize0.8.1Simon Rozman2020-02-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | WireGuard is always doing so-called "minor" upgrade. This makes it enough to run EvaluateWintun only once - somewhere after CostFinalize. The component state we bind our driver install/remove logic to will be a singleton: either be installed, left alone, or uninstalled. One single action for install product session and RemoveExistingProducts session. Other applications using Wintun might use the so-called "major" upgrade. In this scenario the existing product is completely uninstalled first. Including Wintun. The EvaluateWintun was called only once and it determined that Wintun driver should be uninstalled. Since the MSI did not execute EvaluateWintun again when installing the new product later, the Wintun remained uninstalled. In the case of major upgrades, the Wintun requires two separate action logics: what to do with Wintun on uninstall of the old product, and what to do with it when new product is installed. Therefore, EvaluateWintun has been moved between InstallInitialize and InstallFinalize to have MSI execute it in install and uninstall sessions. Reported-by: Dmitry Smirnov <dmitry.smirnov@netprotect.com> Tested-by: Simon Rozman <simon@rozman.si> Signed-off-by: Simon Rozman <simon@rozman.si> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Version bump0.8Jason A. Donenfeld2019-12-101-2/+2
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Invert skipPacket condition so code matchesJason A. Donenfeld2019-12-101-2/+3
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Increment discarded packets properlyJason A. Donenfeld2019-12-101-3/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Process send NBLs in batchesSimon Rozman2019-12-101-59/+63
| | | | | | | | | | | When using packet forwarding on Windows computer, adjacent NBLs may represent packet fragments. Those NBLs must not be completed separately, but in a single NdisMSendNetBufferListsComplete() call. This fixes a bugcheck on Windows Server with RRAS role and IP forwarding packets to Wintun adapter. Signed-off-by: Simon Rozman <simon@rozman.si>