diff options
author | Harsh Shandilya <me@msfjarvis.dev> | 2018-06-02 13:38:36 +0530 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2018-06-02 19:14:56 +0200 |
commit | 4671f59c67db5576ea340a2f586642b3243c85a4 (patch) | |
tree | 87ff1560eed926402bc29b1617f6799c1fd60a03 /app/src/main/java/com/wireguard/android/util/Topic.java | |
parent | crypto: KeyEncoding: Fix style (diff) | |
download | wireguard-android-4671f59c67db5576ea340a2f586642b3243c85a4.tar.xz wireguard-android-4671f59c67db5576ea340a2f586642b3243c85a4.zip |
android: Cleanup classes
- Use final modifer wherever possible
- Use try-with-resources for input/output streams
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Diffstat (limited to '')
-rw-r--r-- | app/src/main/java/com/wireguard/android/util/Topic.java | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/app/src/main/java/com/wireguard/android/util/Topic.java b/app/src/main/java/com/wireguard/android/util/Topic.java index b7aee601..6d8080cf 100644 --- a/app/src/main/java/com/wireguard/android/util/Topic.java +++ b/app/src/main/java/com/wireguard/android/util/Topic.java @@ -28,7 +28,7 @@ public class Topic { subscribers = new SyncArrayList<>(); } - public synchronized void subscribe(Subscriber sub) { + public synchronized void subscribe(final Subscriber sub) { subscribers.add(new WeakReference<>(sub)); } @@ -36,10 +36,10 @@ public class Topic { subscribers = new SyncArrayList<>(); } - public synchronized void unsubscribe(Subscriber sub) { + public synchronized void unsubscribe(final Subscriber sub) { List<WeakReference<Subscriber>> subs = subscribers; subscribers = new ArrayList<>(); - for (WeakReference<Subscriber> subscriber : subs) { + for (final WeakReference<Subscriber> subscriber : subs) { if (subscriber.get() != null && subscriber.get() != sub) subscribers.add(subscriber); } @@ -64,7 +64,7 @@ public class Topic { this.results = results; // Snapshot List<WeakReference<Subscriber>> subs = subscribers; - for (WeakReference<Subscriber> subscriber : subs) { + for (final WeakReference<Subscriber> subscriber : subs) { if (subscriber != null && subscriber.get() != null) subscriber.get().onTopicPublished(this); } @@ -84,7 +84,7 @@ public class Topic { public interface Subscriber { default void subscribeTopics() { - for (Topic topic : getSubscription()) { + for (final Topic topic : getSubscription()) { if (topic.isPublished()) { onTopicPublished(topic); } @@ -92,7 +92,7 @@ public class Topic { } } default void unsubscribeTopics() { - for (Topic event : getSubscription()) { + for (final Topic event : getSubscription()) { event.unsubscribe(this); } } @@ -102,7 +102,7 @@ public class Topic { private static class SyncArrayList<E> extends ArrayList<E> { @Override - public synchronized boolean add(E e) { + public synchronized boolean add(final E e) { return super.add(e); } } |