aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/ui/src/main/java/com (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* ui: distinguish play store installs at runtime for reproducible buildsJason A. Donenfeld2023-04-051-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change lets us use the same build for F-Droid, Play Store, self builds, and elsewhere, which makes everything more easily publicly verifiable, since the build system is reproducible. That means that all APKs will have the same code and be completely interchangeable, no matter where they come from. It does this by removing the build-time branch for special Play Store builds, and replacing it with a simple runtime check using the PackageManager APIs that return the name of the installer. If the app is installed by "com.android.vending", then it's a Play Store install. It's possible to test this with: $ pm install -i com.android.vending path/to/package.apk And it appears to work well. One potential concern is that it's unclear whether the Play Store reviewers install the app using utilities that set com.android.vending like this. If not, that might be a problem. However, it looks like various banking apps also use the installer package name check in the same way, and refuse to start if it's not right. That suggests that it would be impossible for Play Store reviewers to even review those banking apps if they did not set com.android.vending properly. Out of an abundance of caution, though, and in order to avoid a Play Store suspension that's harder to appeal, I sent a support request today (which just managed to fit exactly in the 1000 character limit): Hi, My app pays special attention to Google Play Store guidelines. For that reason, there is some code in the app that looks like this: if (BuildConfig.IS_GOOGLE_PLAY) ... else ... This means that I compile two versions of my app, one for Google Play, and another for other app stores. This has worked well for many years and it satisfies Google's policy requirements. However, compiling two versions of my app is a bit of a pain. Instead, I would like to do this check at runtime, with code like this: if (pm.getInstallSourceInfo(package).installingPackageName == "com.android.vending") ... else ... I have tested that this code works well, and I've installed my app with: $ pm install -i com.android.vending ui-release.apk This works and successfully satisfies the policy requirements. My question is how this works during the review process. Are reviewed apps installed with the necessary -i com.android.vending switch to make this work? Thanks. They responded fairly quickly: Hi Jason, Thanks for contacting the Google Play team. Unfortunately I'm not able to comment on your planned implementation. If you think your app is in compliance, please submit your app for review. You may want to review the Developer Program Policies for additional policy guidance. We recommend reviewing the details listed in this blog post and update your app accordingly to comply with the changes. Thanks for your understanding and continued support. Regards, Mia Google Play Developer Support So I'll interpret that as a, "if you think it's okay, submit it and see, and then we'll let you know." So here we go. Hopefully if it is rejected, the update will only be blocked, and I'll just revert this commit and resubmit. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: always use MaterialAlertDialogBuilderJason A. Donenfeld2023-04-041-3/+5
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: force dark theme in TV modeJason A. Donenfeld2023-04-042-2/+19
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: use real M3 themeing on TVJason A. Donenfeld2023-04-043-5/+58
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: redirect to play store if no file manager on tvJason A. Donenfeld2023-04-041-1/+7
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: detect tv framework stubs when getting contentJason A. Donenfeld2023-04-041-1/+24
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: use ErrorMessages consistentlyJason A. Donenfeld2023-04-042-2/+4
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: do not crash if tunnel preparation failsJason A. Donenfeld2023-04-041-6/+14
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: do not OOM when leaving log window open for a whileJason A. Donenfeld2023-04-041-14/+39
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: show bottom sheet sync to prevent double addJason A. Donenfeld2023-04-041-1/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: do not return to detail page when restoring stateJason A. Donenfeld2023-04-041-4/+14
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: never access CREATOR directlyJason A. Donenfeld2023-04-041-4/+13
| | | | | | | | All of the parcelers have their own type prefix. So we have to actually use the legit methods. This is a bit annoying, as there's no fully compatible way across all API versions, so we have to branch. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: never throw on link clicksJason A. Donenfeld2023-04-042-4/+6
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: do not allow double clicking fab to show menu twiceJason A. Donenfeld2023-03-301-0/+2
| | | | | | | | | | | | | | | | | | | | | Exception java.lang.IllegalStateException: at androidx.fragment.app.FragmentStore.addFragment (FragmentStore.java:92) at androidx.fragment.app.FragmentManager.addFragment (FragmentManager.java:1481) at androidx.fragment.app.BackStackRecord.executeOps (BackStackRecord.java:387) at androidx.fragment.app.FragmentManager.executeOps (FragmentManager.java:1965) at androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:1873) at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:1823) at androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:1760) at androidx.fragment.app.FragmentManager$5.run (FragmentManager.java:547) at android.os.Handler.handleCallback (Handler.java:938) at android.os.Handler.dispatchMessage (Handler.java:99) at android.os.Looper.loop (Looper.java:268) at android.app.ActivityThread.main (ActivityThread.java:8101) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:627) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:997) Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: remove unneeded @JvmStatic annotationsJason A. Donenfeld2023-03-303-8/+1
| | | | | | | These are only needed on methods called from databindings, since those compile to java. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: use app resources instead of ctx for strings in callbackJason A. Donenfeld2023-03-301-1/+1
| | | | | | | | | | | | | | | | | Exception java.lang.IllegalStateException: at androidx.fragment.app.Fragment.requireContext (Fragment.java:967) at com.wireguard.android.fragment.TunnelListFragment$tunnelFileImportResultLauncher$1$1.invokeSuspend (TunnelListFragment.kt:64) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:104) at android.os.Handler.handleCallback (Handler.java:761) at android.os.Handler.dispatchMessage (Handler.java:98) at android.os.Looper.loop (Looper.java:156) at android.app.ActivityThread.main (ActivityThread.java:6617) at java.lang.reflect.Method.invoke at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:942) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:832) Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: use M3 theme for TV to prevent crashJason A. Donenfeld2023-03-301-1/+5
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: add log items in buffered batchesJason A. Donenfeld2023-03-281-23/+34
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: color verbose logs the same as debug logsJason A. Donenfeld2023-03-281-1/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: don't call getColor on already resolved attributeJason A. Donenfeld2023-03-281-1/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: cancel actionmode when pressing back buttonJason A. Donenfeld2023-03-271-0/+8
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: simplify actionmode castJason A. Donenfeld2023-03-271-3/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: introduce a fresh set of Material3 themes and migrate to themHarsh Shandilya2023-03-272-6/+3
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: use AndroidX `BundleCompat` for extracting parcelableHarsh Shandilya2023-03-271-6/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: switch from SwitchMaterial to MaterialSwitchJason A. Donenfeld2023-03-251-2/+2
| | | | | | | | | | This required some weird changes to prevent clipping on the top, because apparently the new switch is a bit fatter. I think this actually looks a bit uglier than before, but it seems like that's what Material design wants. Maybe we can improve it? Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: bring back donation buttonJason A. Donenfeld2023-03-241-0/+38
| | | | | | | | | For Google Play Store builds, we'll display an alert box. This was inspired by the discussion around StreetComplete; hopefully we'll have a similar okay outcome. Link: https://github.com/streetcomplete/streetcomplete/issues/3768 Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: use Material switch componentHarsh Shandilya2023-03-241-2/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: migrate to OnBackPressedDispatcherJason A. Donenfeld2023-03-242-10/+27
| | | | | | | This is compatible with Android 13's prediction-based back gesture animation. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: set selected tunnel after creating fragmentsJason A. Donenfeld2023-03-241-8/+3
| | | | | | | | | | I'm not sure why that comment (Samuel's) was there saying it was necessary. Given it's been async for a long while, this wasn't guaranteed anyway. So let's get rid of it and see what happens. Screen rotation seems fine thus far. Cc: Samuel Holland <samuel@sholland.org> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: switch from using launchWhenCreated to using repeatOnLifecycleJason A. Donenfeld2023-03-241-1/+8
| | | | | | Apparently the former is deprecated. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: simplify IME displaying in ConfigNamingDialogFragmentJason A. Donenfeld2023-03-241-43/+5
| | | | | | Also cleanup some event listener flow. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: migrate to MenuProviderHarsh Shandilya2023-03-222-13/+26
| | | | | | | AndroidX Activity 1.4.0 introduced the new lifecycle-dependent MenuProvider APIs that supersede existing onCreateOptionsMenu-style menus. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: address Parcelable API deprecationsHarsh Shandilya2023-03-222-2/+8
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: address PackageManager API deprecationsHarsh Shandilya2023-03-221-1/+14
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: set button text after loading app list in AppListDialogFragmentJason A. Donenfeld2023-03-221-0/+1
| | | | | | | Otherwise, for lots of apps, the dialog shows before they're enumerated, and the button text never gets set. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* global: bump copyright dateJason A. Donenfeld2023-03-2153-53/+53
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: move default style to Material3 with Dynamic ColorsHarsh Shandilya2022-05-263-2/+6
| | | | | | | The TV theme has been kept as-is since Material You guidance around this is a bit scarce at the moment. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: remove unnecessary boolean checkHarsh Shandilya2022-05-261-3/+1
| | | | | | | | | This check was added in 3c31c340d86f when the kernel module loader was introduced into the app lifecycle, to avoid attempting to start a root shell twice. When the module loader was removed in a03ad51622d338d1c, this flag was accidentally left in when it should have been deleted. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: make validity check from QR code image scanner staticHarsh Shandilya2022-03-062-10/+10
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: allow importing tunnel from an QR image stored on the deviceNikita Pustovoi2022-03-063-1/+134
| | | | | | | | | | | | | | | | | | | | | | | | | Add a new feature to import a tunnel from a saved QR image, this feature integrates into 'import from file' flow, however adds a condition, if file is an image, attempt to parse it as QR image file. My use case for this feature, is to allow easier sharing of tunnels to family. Scanning QR code is ok when you have an external display to show it, but if you sent QR code to someone, there is no way to import it in the app. If you share a config file, that becomes way harder for a non-technical person to import as now they need to find a file with that name in the file picker etc etc, Where the images are very visible in the file picker, and user can easily recognize it for import. Testing: - Click "+" blue button, try to import a valid `.conf` file - the 'original' file flow should not be affected - Click "+" blue button, try to import a valid QR code image - if QR code was parsed, then a new tunnel will be added. - Click "+" blue button, try to import an invalid QR code image - Error message will be shown Signed-off-by: Nikita Pustovoi <deishelon@gmail.com> Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: make when statements exhaustive everywhereHarsh Shandilya2022-01-082-0/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* global: bump copyright yearJason A. Donenfeld2021-10-2952-52/+52
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* tunnel: remove kernel module downloaderJason A. Donenfeld2021-10-295-116/+20
| | | | | | | | Nathan Chance dropped the ball repeatedly and never maintained this in a consistent way that anybody could use. With Android 12 out now, just drop it all together. A bummer, but I don't see much of a choice. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* gradle: upgrade AndroidX dependenciesHarsh Shandilya2021-10-281-2/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: upgrade zxing-android-embeddedHarsh Shandilya2021-10-251-10/+10
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui,tunnel: support DNS search domainsJason A. Donenfeld2021-09-252-1/+7
| | | | | | | | wg-quick has supported this for a while, but not the config layer, and not the Go backend, so wire this all up. Requested-by: Alexis Geoffrey <alexis.geoffrey97@gmail.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* tunnel: retry DNS resolution for 10 secondsJason A. Donenfeld2021-05-261-1/+2
| | | | | | | | | | This has several problems: 1) it blocks the main thread; 2) it doesn't distinguish between a permanent error and a transient one; 3) the 10 seconds is hard coded; 4) there's no way for the user to cancel it. We'll have to improve this. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* build: upgrade AndroidX dependenciesHarsh Shandilya2021-05-191-1/+1
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: update datastore and rework apiJason A. Donenfeld2021-05-063-33/+37
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: remove hack for broken kotlin compilerJason A. Donenfeld2021-05-061-5/+1
| | | | | | Seems like things are finally fixed. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.