aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/ui/src/main (follow)
Commit message (Collapse)AuthorAgeFilesLines
* ui: refactor AddTunnelsSheet's selection communicationHarsh Shandilya2020-09-173-42/+43
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: refactor AppListDialogFragment's selection communicationHarsh Shandilya2020-09-172-33/+31
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* activityx: use contracts more and refineJason A. Donenfeld2020-09-172-26/+22
| | | | | | | This is the beginning; there are still many of the old API's callsites to convert. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* DownloadsFileSaver: encapsulate permission checksJason A. Donenfeld2020-09-174-90/+67
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* LogViewerActivity: simplify scopingJason A. Donenfeld2020-09-161-23/+19
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ZipExporterPreference: don't ask for storage permissions on newer androidJason A. Donenfeld2020-09-162-4/+11
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: resolve getColor deprecation in LogViewerActivityHarsh Shandilya2020-09-161-14/+6
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* LogViewerActivity: destroy process when coroutine scope is cancelledJason A. Donenfeld2020-09-161-37/+42
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: await activity creation to change selected tunnelHarsh Shandilya2020-09-161-2/+1
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: replace GlobalScope with a hand-rolled CoroutineScopeHarsh Shandilya2020-09-166-16/+25
| | | | | | | | | | | | | | | | | GlobalScope has numerous problems[1] that make it unfit for use in most applications and making it behave correctly requires an excessive amount of verbosity that's alleviated simply by using any other scope. Since we run multiple operations in the context of the application's lifecycle, introduce a new scope that is created when our application is, and cancelled upon its termination. While at it, make the scope default to Dispatchers.IO to reduce pressure on the UI event loop. Tasks requiring access to the UI thread appropriately switch context making the change completely safe. 1: https://medium.com/@elizarov/the-reason-to-avoid-globalscope-835337445abc Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ConfigNamingDialogFragment: fix focus request for config naming dialogHarsh Shandilya2020-09-162-5/+18
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* TunnelEditorFragment: move backwards using fragment manager instead of hackJason A. Donenfeld2020-09-162-7/+5
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* TunnelEditorFragment: avoid extra trip through event loopJason A. Donenfeld2020-09-161-7/+6
| | | | | | | | | onSelectedTunnelChanged is already queueing us to Dispatchers.Main (rather than Dispatchers.Main.immediate, which would crash, but why?), so avoid the extra trip through the event loop by toggling the selected tunnel right away. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* Extensions: use more idiomatic kotlinJason A. Donenfeld2020-09-161-2/+2
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* global: lint codebase with recent changesJason A. Donenfeld2020-09-168-7/+12
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: don't use low-level logger APIHarsh Shandilya2020-09-164-7/+7
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: update manifest for API 30 changesHarsh Shandilya2020-09-161-1/+11
| | | | | | | | - Mark WRITE_EXTERNAL_STORAGE as unused above API 29 since we defer to Storage Access Framework on P and above - Adds a <queries> tag to allow listing apps for exclusion/inclusion dialog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* coroutines: lifecycleScope is by default on Main.immediateJason A. Donenfeld2020-09-1613-29/+23
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* coroutines: use lifecycleScope where appropriateJason A. Donenfeld2020-09-1517-81/+63
| | | | | | | There's still a bit of GlobalScope lingering around, which might be removable. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* MonkeyedTextInputEditText: au revoirJason A. Donenfeld2020-09-153-44/+13
| | | | | | | Remember to go back to using com.google.android.material when 1.3.0-alpha03 comes out. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* TunnelListFragment: set selection on Main, not Main.immediateJason A. Donenfeld2020-09-151-1/+1
| | | | | | Otherwise, we crash when saving the config. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* MonkeyedTextInputEditText: add note about sunset planJason A. Donenfeld2020-09-151-0/+6
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* gradle: desugar retrofuture and remove old depsJason A. Donenfeld2020-09-153-11/+11
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* coroutines: convert the restJason A. Donenfeld2020-09-1523-532/+569
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* coroutines: convert low-hanging fruitsJason A. Donenfeld2020-09-145-73/+106
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: remove hacky manual check for keyguardHarsh Shandilya2020-09-131-20/+1
| | | | | | Setting the correct value for the allowedAuthenticators field lets the library correctly detect this by itself as verified on an API 21 emulator Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: update BiometricAuthenticator for API changesHarsh Shandilya2020-09-131-2/+6
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: fix memory leak from statically held Handler instanceHarsh Shandilya2020-09-131-2/+1
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: fix SDK 30 deprecation warning for implicit Looper in Handler initHarsh Shandilya2020-08-231-1/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: also enable StrictMode thread policy in debug buildsHarsh Shandilya2020-08-231-0/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* AdminKnobs: allow enterprise admins to disable private key exportJason A. Donenfeld2020-07-237-0/+43
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* strings: sync translationsHarsh Shandilya2020-06-023-12/+268
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: address new databinding requirementsHarsh Shandilya2020-05-293-8/+9
| | | | | | | | | | Layouts in differing configurations must agree on their root tags, so we give both copies of main_activity the same root ID, and adjust the check for two-pane layout to simply test for nullability. This also changes the inset dispatch code to use ViewCompat and WindowInsetsCompat since they will adjust insets based on the SDK level allowing us to abstract away that concern. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: remove unneeded actionBarPopupTheme attributeHarsh Shandilya2020-05-093-3/+0
| | | | | | This caused inconsistencies between our overflow icon and actionbar title's tint Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: switch up dark theme system bars colorsHarsh Shandilya2020-04-261-2/+2
| | | | | | | | | The status bar color had a subtle transparency applied which caused inconsistencies, and the navigation bar color was the wrong shade of gray. Reported-by: Danny Lin <danny@kdrag0n.dev> Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: tweak fab animation durationHarsh Shandilya2020-04-192-2/+2
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* strings: sync translationsHarsh Shandilya2020-04-195-35/+144
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: animate fab scale rather than translationHarsh Shandilya2020-04-163-19/+53
| | | | | Suggested-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ObservableTunnel: account for race in renulling statsJason A. Donenfeld2020-04-151-2/+2
| | | | | | | | | | | | | | The stats might become null between these two checks, when a tunnel flips off, resulting in a null pointer dereference: at com.wireguard.android.model.ObservableTunnel.getStatisticsAsync (ObservableTunnel.java:103) at com.wireguard.android.fragment.TunnelDetailFragment.updateStats (TunnelDetailFragment.java:108) at com.wireguard.android.fragment.TunnelDetailFragment.access$updateStats (TunnelDetailFragment.java:27) at com.wireguard.android.fragment.TunnelDetailFragment$onResume$1.run (TunnelDetailFragment.java:74) at java.util.TimerThread.mainLoop (TimerThread.java:562) at java.util.TimerThread.run (TimerThread.java:512) Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: animate fab position in tunnel deletion flowHarsh Shandilya2020-04-081-0/+19
| | | | | | | | When tunnel deletion is triggered we don't bother with animation theatrics because the resulting Snackbar needs this fab to be its anchor, which it can't do if its outside the screen or busy animating. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* strings: sync translationsHarsh Shandilya2020-04-083-130/+239
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: tweak FABs to use the correct typeHarsh Shandilya2020-04-083-9/+7
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* ui: codestyle nitHarsh Shandilya2020-04-071-2/+4
| | | | Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
* KernelModuleDisablerPreference: do not make synchronous calls to getBackendJason A. Donenfeld2020-04-071-8/+17
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: set proper content description for applicationsJason A. Donenfeld2020-04-061-1/+1
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: show excluded/included apps in details viewJason A. Donenfeld2020-04-062-0/+33
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: align listen port and mtu in detail editorJason A. Donenfeld2020-04-061-7/+17
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: add suffix to persistent keepalive in editorJason A. Donenfeld2020-04-063-1/+19
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* ui: add missing fields to detail viewJason A. Donenfeld2020-04-0612-16/+157
| | | | Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
* TunnelListFragment: onCreateActionMode is called before adapter is aliveJason A. Donenfeld2020-04-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Long press a tunnel item. SIGKILL the app. Reenter it. Boom: kotlin.KotlinNullPointerException: at com.wireguard.android.fragment.TunnelListFragment$ActionModeListener.onCreateActionMode (TunnelListFragment.java:347) at androidx.appcompat.app.AppCompatDelegateImpl$ActionModeCallbackWrapperV9.onCreateActionMode (AppCompatDelegateImpl.java:2442) at androidx.appcompat.app.WindowDecorActionBar$ActionModeImpl.dispatchOnCreate (WindowDecorActionBar.java:1062) at androidx.appcompat.app.WindowDecorActionBar.startActionMode (WindowDecorActionBar.java:530) at androidx.appcompat.app.AppCompatDelegateImpl.startSupportActionMode (AppCompatDelegateImpl.java:1055) at androidx.appcompat.app.AppCompatActivity.startSupportActionMode (AppCompatActivity.java:316) at com.wireguard.android.fragment.TunnelListFragment$ActionModeListener.setItemChecked (TunnelListFragment.java:371) at com.wireguard.android.fragment.TunnelListFragment.onActivityCreated (TunnelListFragment.java:174) at androidx.fragment.app.Fragment.performActivityCreated (Fragment.java:2717) at androidx.fragment.app.FragmentStateManager.activityCreated (FragmentStateManager.java:346) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1188) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:161) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1356) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:5) at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState (FragmentManager.java:1434) at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState (FragmentManager.java:5) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1497) at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:389) at androidx.fragment.app.FragmentManager.dispatchStateChange (FragmentManager.java:2625) at androidx.fragment.app.FragmentManager.dispatchStateChange (FragmentManager.java:677) at androidx.fragment.app.FragmentManager.dispatchActivityCreated (FragmentManager.java:2577) at androidx.fragment.app.FragmentManager.dispatchActivityCreated (FragmentManager.java:9) at androidx.fragment.app.FragmentController.dispatchActivityCreated (FragmentController.java:247) at androidx.fragment.app.FragmentActivity.onStart (FragmentActivity.java:541) at androidx.appcompat.app.AppCompatActivity.onStart (AppCompatActivity.java:201) at android.app.Instrumentation.callActivityOnStart (Instrumentation.java:1440) at android.app.Activity.performStart (Activity.java:8109) at android.app.ActivityThread.handleStartActivity (ActivityThread.java:3806) at android.app.servertransaction.TransactionExecutor.performLifecycleSequence (TransactionExecutor.java:235) at android.app.servertransaction.TransactionExecutor.cycleToPath (TransactionExecutor.java:215) at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:187) at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:105) at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2386) at android.os.Handler.dispatchMessage (Handler.java:107) at android.os.Looper.loop (Looper.java:213) at android.app.ActivityThread.main (ActivityThread.java:8178) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:513) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1101) This commit avoids the crash. But it's not clear to me that this is really the right solution. However, in testing it appears to work. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>