From 402472237e8f6100573e9c3d41965a2e17e79578 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Tue, 24 Jul 2018 13:39:50 +0530 Subject: config: Remove Locale based string format The configurations are supposed to be in a very specific format which is not user-facing and hence doesn't have to be adjusted for locale avoiding both the redundancy as well as potential breakages in the configuration file format from different locales. Fixes: 71c67aa24ae2 ("config: Minor cleanup") Reported-by: Samuel Holland Signed-off-by: Harsh Shandilya --- app/src/main/java/com/wireguard/config/Attribute.java | 3 +-- app/src/main/java/com/wireguard/config/Peer.java | 9 +++------ 2 files changed, 4 insertions(+), 8 deletions(-) (limited to 'app/src/main/java/com/wireguard') diff --git a/app/src/main/java/com/wireguard/config/Attribute.java b/app/src/main/java/com/wireguard/config/Attribute.java index e8b731b5..b35df100 100644 --- a/app/src/main/java/com/wireguard/config/Attribute.java +++ b/app/src/main/java/com/wireguard/config/Attribute.java @@ -10,7 +10,6 @@ import android.support.annotation.Nullable; import android.text.TextUtils; import java.util.HashMap; -import java.util.Locale; import java.util.Map; import java.util.regex.Matcher; import java.util.regex.Pattern; @@ -71,7 +70,7 @@ public enum Attribute { } public String composeWith(final int value) { - return String.format(Locale.getDefault(), "%s = %d%n", token, value); + return String.format("%s = %d%n", token, value); } public String composeWith(final Iterable value) { diff --git a/app/src/main/java/com/wireguard/config/Peer.java b/app/src/main/java/com/wireguard/config/Peer.java index b3532eeb..2a4f4465 100644 --- a/app/src/main/java/com/wireguard/config/Peer.java +++ b/app/src/main/java/com/wireguard/config/Peer.java @@ -25,7 +25,6 @@ import java.util.Arrays; import java.util.Collection; import java.util.HashSet; import java.util.List; -import java.util.Locale; import java9.lang.Iterables; @@ -72,7 +71,7 @@ public class Peer { private String getEndpointString() { if (endpoint == null) return null; - return String.format(Locale.getDefault(), "%s:%d", endpoint.getHostString(), endpoint.getPort()); + return String.format("%s:%d", endpoint.getHostString(), endpoint.getPort()); } public int getPersistentKeepalive() { @@ -104,12 +103,10 @@ public class Peer { if (endpoint.isUnresolved()) throw new UnknownHostException(endpoint.getHostString()); if (endpoint.getAddress() instanceof Inet6Address) - return String.format(Locale.getDefault(), - "[%s]:%d", + return String.format("[%s]:%d", endpoint.getAddress().getHostAddress(), endpoint.getPort()); - return String.format(Locale.getDefault(), - "%s:%d", + return String.format("%s:%d", endpoint.getAddress().getHostAddress(), endpoint.getPort()); } -- cgit v1.2.3-59-g8ed1b