From dfb685f2580403cc28aeae7428d52f3655d3436b Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Thu, 23 Sep 2021 05:39:47 +0200 Subject: WireGuardApp: restore old keychain consistency behavior This reverts commit adcbd17ebeedaf6fa8106c8835ebf43667170878. Signed-off-by: Jason A. Donenfeld --- Sources/WireGuardApp/Tunnel/TunnelsManager.swift | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'Sources/WireGuardApp/Tunnel/TunnelsManager.swift') diff --git a/Sources/WireGuardApp/Tunnel/TunnelsManager.swift b/Sources/WireGuardApp/Tunnel/TunnelsManager.swift index 152d26e..83c48c9 100644 --- a/Sources/WireGuardApp/Tunnel/TunnelsManager.swift +++ b/Sources/WireGuardApp/Tunnel/TunnelsManager.swift @@ -56,19 +56,21 @@ class TunnelsManager { tunnelManager.saveToPreferences { _ in } } #if os(iOS) - let verify = true + let passwordRef = proto.verifyConfigurationReference() ? proto.passwordReference : nil #elseif os(macOS) - let verify = proto.providerConfiguration?["UID"] as? uid_t == getuid() + let passwordRef: Data? + if proto.providerConfiguration?["UID"] as? uid_t == getuid() { + passwordRef = proto.verifyConfigurationReference() ? proto.passwordReference : nil + } else { + passwordRef = proto.passwordReference // To handle multiple users in macOS, we skip verifying + } #else #error("Unimplemented") #endif - if verify && !proto.verifyConfigurationReference() { - wg_log(.error, message: "Unable to verify keychain entry of tunnel: \(tunnelManager.localizedDescription ?? "")") - } - if let ref = proto.passwordReference { + if let ref = passwordRef { refs.insert(ref) } else { - wg_log(.error, message: "Removing orphaned tunnel with missing keychain entry: \(tunnelManager.localizedDescription ?? "")") + wg_log(.info, message: "Removing orphaned tunnel with non-verifying keychain entry: \(tunnelManager.localizedDescription ?? "")") tunnelManager.removeFromPreferences { _ in } tunnelManagers.remove(at: index) } -- cgit v1.2.3-59-g8ed1b