diff options
author | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-04-21 21:33:38 -0600 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-04-22 00:39:13 -0600 |
commit | 47a6d9c35e8d6aec14ea82c0ed381eba13bd2378 (patch) | |
tree | ca835b4179a1560f0a52bbb58991fdda4d8c94d0 | |
parent | if_wg: add more usual string concat spacing (diff) | |
download | wireguard-freebsd-47a6d9c35e8d6aec14ea82c0ed381eba13bd2378.tar.xz wireguard-freebsd-47a6d9c35e8d6aec14ea82c0ed381eba13bd2378.zip |
TODO: more nits
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
-rw-r--r-- | TODO.md | 14 |
1 files changed, 12 insertions, 2 deletions
@@ -8,9 +8,19 @@ FreeBSD, just `capable()`, which makes it a bit weird for one jail to have permissions in another.) - Make code style consistent with one FreeBSD way, rather than a mix of styles. -- Run ratelimiter gc in a properly scheduled manner. - Make sure noise state machine is correct. -- Clear mbuf tags and other members properly. +- The cookie logic appears to be broken in unusual ways, in particular right + after boot up. Audit and compare all `is_valid` checks, as well as + `have_sent_mac1` guards. +- Investigate whether the allowed ips lookup structure needs reference + counting. +- Handle failures of `rn_inithead` and remember to call `rn_detachhead` + somewhere during cleanup. +- Stop using `M_WAITOK` and use `M_NOWAIT` instead. +- Make sure ratelimiter is empty and deinited. +- Check return value of `rn_inithead`. +- Perhaps call `rn_detachhead` to free memory when destroying aip. +- Have one rate limiter table per module, and hash in jail/fib pointer. ### Crypto TODO |