From 47a6d9c35e8d6aec14ea82c0ed381eba13bd2378 Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Wed, 21 Apr 2021 21:33:38 -0600 Subject: TODO: more nits Signed-off-by: Jason A. Donenfeld --- TODO.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'TODO.md') diff --git a/TODO.md b/TODO.md index bf84964..9b5ffc3 100644 --- a/TODO.md +++ b/TODO.md @@ -8,9 +8,19 @@ FreeBSD, just `capable()`, which makes it a bit weird for one jail to have permissions in another.) - Make code style consistent with one FreeBSD way, rather than a mix of styles. -- Run ratelimiter gc in a properly scheduled manner. - Make sure noise state machine is correct. -- Clear mbuf tags and other members properly. +- The cookie logic appears to be broken in unusual ways, in particular right + after boot up. Audit and compare all `is_valid` checks, as well as + `have_sent_mac1` guards. +- Investigate whether the allowed ips lookup structure needs reference + counting. +- Handle failures of `rn_inithead` and remember to call `rn_detachhead` + somewhere during cleanup. +- Stop using `M_WAITOK` and use `M_NOWAIT` instead. +- Make sure ratelimiter is empty and deinited. +- Check return value of `rn_inithead`. +- Perhaps call `rn_detachhead` to free memory when destroying aip. +- Have one rate limiter table per module, and hash in jail/fib pointer. ### Crypto TODO -- cgit v1.2.3-59-g8ed1b