wireguard-go, branch js/sample-api

device: add Device.ListenPort and Device.SetListenPort

2020-12-22T19:29:28Z

This is a sample commit for a possible way to make a Go API that lives alongside UAPI. The general idea is to add Device and Peer methods corresponding to UAPI directives, including a way to look up a peer from a device based on a public key, as in UAPI. The UAPI code then deals with parsing and generating textual input/output, and calls the Go methods to do the work. This commit also contains a bug fix for a racy access of device.net.port I will send an independently commit that fixes those directly in UAPI. This commit is NOT meant to be merged as-is. Signed-off-by: Josh Bleecher Snyder

device: add UAPI helper methods

2020-12-22T13:30:57Z

Signed-off-by: Jason A. Donenfeld

tun: make customization of WintunPool and WintunGUID more obvious

2020-12-22T13:16:06Z

Persnickety consumers can now do: func init() { tun.WintunPool, _ = wintun.Pool("Flurp") tun.WintunStaticRequestedGUID, _ = windows.GUIDFromString("{5ae2716f-0b3e-4dc4-a8b5-48eba11a6e16}") } Signed-off-by: Jason A. Donenfeld

conn: do not SO_REUSEADDR on linux

2020-12-18T22:39:23Z

SO_REUSEADDR does not make sense for unicast UDP sockets. Signed-off-by: Jason A. Donenfeld

device: add missing colon to error line

2020-12-18T19:18:47Z

People are actually hitting this condition, so make it uniform. Also, change a printf into a println, to match the other conventions. Signed-off-by: Jason A. Donenfeld

device: fix error shadowing before log print

2020-12-17T11:15:14Z

Signed-off-by: Brad Fitzpatrick

device: fix data race in peer.timersActive

2020-12-17T00:16:26Z

Found by the race detector and existing tests. To avoid introducing a lock into this hot path, calculate and cache whether any peers exist. Signed-off-by: Josh Bleecher Snyder

device: fix races from changing private_key

2020-12-17T00:16:26Z

Access keypair.sendNonce atomically. Eliminate one unnecessary initialization to zero. Mutate handshake.lastSentHandshake with the mutex held. Co-authored-by: David Anderson Signed-off-by: Josh Bleecher Snyder

device: always name QueueElement variables elem

2020-12-17T00:16:26Z

They're called elem in most places. Rename a few local variables to make it consistent. This makes it easier to grep the code for things like elem.Drop. Signed-off-by: Josh Bleecher Snyder

device: use channel close to shut down and drain outbound channel

2020-12-17T00:16:26Z

This is a similar treatment to the handling of the encryption channel found a few commits ago: Use the closing of the channel to manage goroutine lifetime and shutdown. It is considerably simpler because there is only a single writer. Signed-off-by: Josh Bleecher Snyder

wireguard-go, branch js/sample-api

device: add Device.ListenPort and Device.SetListenPort

device: add UAPI helper methods

tun: make customization of WintunPool and WintunGUID more obvious

conn: do not SO_REUSEADDR on linux

device: add missing colon to error line

device: fix error shadowing before log print

device: fix data race in peer.timersActive

device: fix races from changing private_key

device: always name *Queue*Element variables elem

device: use channel close to shut down and drain outbound channel

device: always name QueueElement variables elem