wireguard-go, branch masterGo implementation of WireGuardhttps://git.zx2c4.com/wireguard-go/atom/?h=master2025-05-21T23:45:02Zversion: bump snapshot2025-05-21T23:45:02ZJason A. DonenfeldJason@zx2c4.com2025-05-21T23:45:02Zurn:sha1:f333402bd9cbe0f3eeb02507bd14e23d7d639280
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
conn: don't enable GRO on Linux < 5.122025-05-21T23:43:39ZJason A. DonenfeldJason@zx2c4.com2025-05-21T23:33:55Zurn:sha1:c92064f1ce35f82bf0c5a183b54e51fd5d58ad50
Kernels below 5.12 are missing this:
commit 98184612aca0a9ee42b8eb0262a49900ee9eef0d
Author: Norman Maurer <norman_maurer@apple.com>
Date: Thu Apr 1 08:59:17 2021
net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);
Support for UDP_GRO was added in the past but the implementation for
getsockopt was missed which did lead to an error when we tried to
retrieve the setting for UDP_GRO. This patch adds the missing switch
case for UDP_GRO
Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
Signed-off-by: Norman Maurer <norman_maurer@apple.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
That means we can't set the option and then read it back later. Given
how buggy UDP_GRO is in general on odd kernels, just disable it on older
kernels all together.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
device: optimize message encoding2025-05-20T22:09:36ZAlexander Yastrebovyastrebov.alex@gmail.com2025-05-17T09:34:30Zurn:sha1:264889f0bbdf9250bb8389a637dd5f38389bfe0b
Optimize message encoding by eliminating binary.Write (which internally
uses reflection) in favour of hand-rolled encoding.
This is companion to 9e7529c3d2d0c54f4d5384c01645a9279e4740ae.
Synthetic benchmark:
var packetSink []byte
func BenchmarkMessageInitiationMarshal(b *testing.B) {
var msg MessageInitiation
b.Run("binary.Write", func(b *testing.B) {
b.ReportAllocs()
for range b.N {
var buf [MessageInitiationSize]byte
writer := bytes.NewBuffer(buf[:0])
_ = binary.Write(writer, binary.LittleEndian, msg)
packetSink = writer.Bytes()
}
})
b.Run("binary.Encode", func(b *testing.B) {
b.ReportAllocs()
for range b.N {
packet := make([]byte, MessageInitiationSize)
_, _ = binary.Encode(packet, binary.LittleEndian, msg)
packetSink = packet
}
})
b.Run("marshal", func(b *testing.B) {
b.ReportAllocs()
for range b.N {
packet := make([]byte, MessageInitiationSize)
_ = msg.marshal(packet)
packetSink = packet
}
})
}
Results:
│ - │
│ sec/op │
MessageInitiationMarshal/binary.Write-8 1.337µ ± 0%
MessageInitiationMarshal/binary.Encode-8 1.242µ ± 0%
MessageInitiationMarshal/marshal-8 53.05n ± 1%
│ - │
│ B/op │
MessageInitiationMarshal/binary.Write-8 368.0 ± 0%
MessageInitiationMarshal/binary.Encode-8 160.0 ± 0%
MessageInitiationMarshal/marshal-8 160.0 ± 0%
│ - │
│ allocs/op │
MessageInitiationMarshal/binary.Write-8 3.000 ± 0%
MessageInitiationMarshal/binary.Encode-8 1.000 ± 0%
MessageInitiationMarshal/marshal-8 1.000 ± 0%
Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
device: add support for removing allowedips individually2025-05-20T21:03:06ZJason A. DonenfeldJason@zx2c4.com2025-05-20T21:03:06Zurn:sha1:256bcbd70d5b4eaae2a9f21a9889498c0f89041c
This pairs with the recent change in wireguard-tools.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
version: bump snapshot2025-05-15T14:54:03ZJason A. DonenfeldJason@zx2c4.com2025-05-15T14:54:03Zurn:sha1:1571e0fbae8e1d955e05dde80071bc86880d61b3
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
device: make unmarshall length checks exact2025-05-15T14:48:14ZJason A. DonenfeldJason@zx2c4.com2025-05-15T14:48:14Zurn:sha1:842888ac5c93ccc5ee6344eceaadf783fcf1e243
This is already enforced in receive.go, but if these unmarshallers are
to have error return values anyway, make them as explicit as possible.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
device: reduce RoutineHandshake allocations2025-05-15T14:42:06ZAlexander Yastrebovyastrebov.alex@gmail.com2024-12-26T19:36:53Zurn:sha1:9e7529c3d2d0c54f4d5384c01645a9279e4740ae
Reduce allocations by eliminating byte reader, hand-rolled decoding and
reusing message structs.
Synthetic benchmark:
var msgSink MessageInitiation
func BenchmarkMessageInitiationUnmarshal(b *testing.B) {
packet := make([]byte, MessageInitiationSize)
reader := bytes.NewReader(packet)
err := binary.Read(reader, binary.LittleEndian, &msgSink)
if err != nil {
b.Fatal(err)
}
b.Run("binary.Read", func(b *testing.B) {
b.ReportAllocs()
for range b.N {
reader := bytes.NewReader(packet)
_ = binary.Read(reader, binary.LittleEndian, &msgSink)
}
})
b.Run("unmarshal", func(b *testing.B) {
b.ReportAllocs()
for range b.N {
_ = msgSink.unmarshal(packet)
}
})
}
Results:
│ - │
│ sec/op │
MessageInitiationUnmarshal/binary.Read-8 1.508µ ± 2%
MessageInitiationUnmarshal/unmarshal-8 12.66n ± 2%
│ - │
│ B/op │
MessageInitiationUnmarshal/binary.Read-8 208.0 ± 0%
MessageInitiationUnmarshal/unmarshal-8 0.000 ± 0%
│ - │
│ allocs/op │
MessageInitiationUnmarshal/binary.Read-8 2.000 ± 0%
MessageInitiationUnmarshal/unmarshal-8 0.000 ± 0%
Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
rwcancel: fix wrong poll event flag on ReadyWrite2025-05-05T13:10:08ZKurnia D Winkurnia.d.win@gmail.com2023-06-07T05:41:02Zurn:sha1:436f7fdc1670df26eee958de464cf5cb0385abec
It should be POLLIN because closeFd is read-only file.
Signed-off-by: Kurnia D Win <kurnia.d.win@gmail.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
device: use rand.NewSource instead of rand.Seed2025-05-05T13:10:08ZTom Holfordtomholford@users.noreply.github.com2025-05-04T16:49:49Zurn:sha1:0e4482a086cb6dd9bb2baac8b538d1dbf354c136
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
global: replaced unused function params with _2025-05-05T13:10:08ZTom Holfordtomholford@users.noreply.github.com2025-05-04T16:49:03Zurn:sha1:77b6c824a8225328aebca78eba676ea7eb606a69
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>