wireguard-go/ratelimiter, branch js/sample-apiGo implementation of WireGuardhttps://git.zx2c4.com/wireguard-go/atom/ratelimiter?h=js%2Fsample-api2020-05-02T08:08:26Zglobal: update header comments and modules2020-05-02T08:08:26ZJason A. DonenfeldJason@zx2c4.com2020-05-02T08:08:26Zurn:sha1:db0aa39b765243c6a4ac9a2e348311df9517c0bf
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
ratelimiter: use a fake clock in tests and style cleanups2020-03-30T07:38:36ZDavid Crawshawcrawshaw@tailscale.com2019-12-08T23:22:31Zurn:sha1:9cd8909df2ad882b81b611b4656020aeceb6c9b2
The existing test would occasionally flake out with:
--- FAIL: TestRatelimiter (0.12s)
ratelimiter_test.go:99: Test failed for 127.0.0.1 , on: 7 ( not having refilled enough ) expected: false got: true
FAIL
FAIL golang.zx2c4.com/wireguard/ratelimiter 0.171s
The fake clock also means the tests run much faster, so
testing this package with -count=1000 now takes < 100ms.
While here, several style cleanups. The most significant one
is unembeding the sync.Mutex fields in the rate limiter objects.
Embedded as they were, the lock methods were accessible
outside the ratelimiter package. As they aren't needed externally,
keep them internal to make them easier to reason about.
Passes `go test -race -count=10000 ./ratelimiter`
Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
global: fix a few typos courtesy of codespell2019-10-22T09:51:25ZJonathan Tookerjonathan.tooker@netprotect.com2019-10-21T20:52:26Zurn:sha1:f7d0edd2ecf5f7f5aed188823de0a122691a7de6
Signed-off-by: Jonathan Tooker <jonathan.tooker@netprotect.com>
device, ratelimiter: replace uses of time.Now().Sub() with time.Since()2019-06-03T20:15:41ZMatt Layhermdlayher@gmail.com2019-06-03T19:46:46Zurn:sha1:18b6627f33883e28dd69b2990c52359002856694
Simplification found by staticcheck:
$ staticcheck ./... | grep S1012
device/cookie.go:90:5: should use time.Since instead of time.Now().Sub (S1012)
device/cookie.go:127:5: should use time.Since instead of time.Now().Sub (S1012)
device/cookie.go:242:5: should use time.Since instead of time.Now().Sub (S1012)
device/noise-protocol.go:304:13: should use time.Since instead of time.Now().Sub (S1012)
device/receive.go:82:46: should use time.Since instead of time.Now().Sub (S1012)
device/send.go:132:5: should use time.Since instead of time.Now().Sub (S1012)
device/send.go:139:5: should use time.Since instead of time.Now().Sub (S1012)
device/send.go:235:59: should use time.Since instead of time.Now().Sub (S1012)
device/send.go:393:9: should use time.Since instead of time.Now().Sub (S1012)
ratelimiter/ratelimiter.go:79:10: should use time.Since instead of time.Now().Sub (S1012)
ratelimiter/ratelimiter.go:87:10: should use time.Since instead of time.Now().Sub (S1012)
Change applied using:
$ find . -type f -name "*.go" -exec sed -i "s/Now().Sub(/Since(/g" {} \;
Signed-off-by: Matt Layher <mdlayher@gmail.com>
Extend structs rather than embed, when possible2019-02-05T11:59:42ZJason A. DonenfeldJason@zx2c4.com2019-01-03T18:04:00Zurn:sha1:89d2c5ed7a054bc05a21209d5a9c79ad7151f8f7Update copyright2019-02-05T11:59:42ZJason A. DonenfeldJason@zx2c4.com2019-01-02T00:55:51Zurn:sha1:dff424baf8acc4d2a5858d3947761c5090d8e640global: fix up copyright headers2018-09-16T16:49:19ZJason A. DonenfeldJason@zx2c4.com2018-09-05T21:54:31Zurn:sha1:5be541d147562bf87f6a9ebd551412d4a6920b4bratelimiter: do not run GC with nothing to do2018-05-21T01:20:18ZJason A. DonenfeldJason@zx2c4.com2018-05-21T01:18:56Zurn:sha1:e28d70f5b2a00af75aa9f283e31c7da31a2913dfCleanup ratelimiter2018-05-13T16:42:06ZJason A. DonenfeldJason@zx2c4.com2018-05-13T16:42:06Zurn:sha1:e94185681f4c19874392019b0d43bdfefcbb85b5global: Add SPDX tags and copyright header2018-05-03T13:06:25ZJason A. DonenfeldJason@zx2c4.com2018-05-03T13:04:00Zurn:sha1:a040786645ec980059937fd6a1a361b160c1a809
Mathias should probably add his copyright headers to each file too.