wireguard-go/tun, branch fw/codeQuality

global: update header comments and modules

2020-05-02T08:08:26Z

Signed-off-by: Jason A. Donenfeld

wintun: make remaining HWID comparisons case insensitive

2020-05-02T07:50:47Z

c85e4a410f27986a2967a49c0155633c716bf3ca introduced preliminary HWID checking to speed up Wintun adapter enumeration. However, all HWID are case insensitive by Windows convention. Furthermore, a device might have multiple HWIDs. When DevInfo's DeviceRegistryProperty(SPDRP_HARDWAREID) method returns []string, all strings returned should be checked against given hardware ID. This issue was discovered when researching Wintun and wireguard-go on Windows 10 ARM64. The Wintun adapter was created using devcon.exe utility with "wintun" hardware ID, causing wireguard-go fail to enumerate the adapter properly. Signed-off-by: Simon Rozman

setupapi: extend struct size constant definitions for arm(64)

2020-05-02T07:50:47Z

Signed-off-by: Simon Rozman

tun: return a better error message if /dev/net/tun doesn't exist

2020-05-02T07:50:47Z

It was just returning "no such file or directory" (the String of the syscall.Errno returned by CreateTUN). Signed-off-by: Brad Fitzpatrick

tun: NetlinkListener: don't send EventDown before sending EventUp

2020-05-02T07:46:42Z

This works around a startup race condition when competing with HackListener, which is trying to do the same job. If HackListener detects that the tundev is running while there is still an event in the netlink queue that says it isn't running, then the device receives a string of events like EventUp (HackListener) EventDown (NetlinkListener) EventUp (NetlinkListener) Unfortunately, after the first EventDown, the device stops itself, thinking incorrectly that the administrator has downed its tundev. The device is ignoring the initial EventDown anyway, so just don't emit it. Signed-off-by: Avery Pennarun

tuntest: split out testing package

2020-05-02T07:46:42Z

This code is useful to other packages writing tests. Signed-off-by: David Crawshaw

tun: fix data race on name field

2020-05-02T07:46:42Z

Signed-off-by: Brad Fitzpatrick

tun: remove unused isUp method

2020-05-02T07:46:42Z

Signed-off-by: Brad Fitzpatrick

wintun: split error message for create vs open namespace.

2020-05-02T07:44:58Z

Signed-off-by: Avery Pennarun

global: use RTMGRP_* consts from x/sys/unix

2020-03-18T05:07:11Z

Update the golang.org/x/sys/unix dependency and use the newly introduced RTMGRP_* consts instead of using the corresponding RTNLGRP_* const to create a mask. Signed-off-by: Tobias Klauser