diff options
| author |   David Crawshaw <crawshaw@tailscale.com> | 2019-12-08 18:22:31 -0500 |
|---|---|---|
| committer |   David Crawshaw <david@zentus.com> | 2020-03-30 18:38:36 +1100 |
| commit | 9cd8909df2ad882b81b611b4656020aeceb6c9b2 (patch) | |
| tree | 3e09b88bfdf9069d96b4c98ef39aeaea7b5b1d3a /rwcancel/rwcancel_windows.go | |
| parent | version: bump snapshot (diff) | |
| download | wireguard-go-9cd8909df2ad882b81b611b4656020aeceb6c9b2.tar.xz wireguard-go-9cd8909df2ad882b81b611b4656020aeceb6c9b2.zip | |
ratelimiter: use a fake clock in tests and style cleanups
The existing test would occasionally flake out with:
--- FAIL: TestRatelimiter (0.12s)
ratelimiter_test.go:99: Test failed for 127.0.0.1 , on: 7 ( not having refilled enough ) expected: false got: true
FAIL
FAIL golang.zx2c4.com/wireguard/ratelimiter 0.171s
The fake clock also means the tests run much faster, so
testing this package with -count=1000 now takes < 100ms.
While here, several style cleanups. The most significant one
is unembeding the sync.Mutex fields in the rate limiter objects.
Embedded as they were, the lock methods were accessible
outside the ratelimiter package. As they aren't needed externally,
keep them internal to make them easier to reason about.
Passes `go test -race -count=10000 ./ratelimiter`
Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions