From 34babb386e6a22706ba7d4cdf35a8f112c14e3da Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Wed, 22 Apr 2020 23:32:26 -0600 Subject: queueing: cleanup ptr_ring in error path of packet_queue_init Prior, if the alloc_percpu of packet_percpu_multicore_worker_alloc failed, the previously allocated ptr_ring wouldn't be freed. This commit adds the missing call to ptr_ring_cleanup in the error case. Reported-by: Sultan Alsawaf Signed-off-by: Jason A. Donenfeld --- src/queueing.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/queueing.c b/src/queueing.c index 5c964fc..71b8e80 100644 --- a/src/queueing.c +++ b/src/queueing.c @@ -35,8 +35,10 @@ int wg_packet_queue_init(struct crypt_queue *queue, work_func_t function, if (multicore) { queue->worker = wg_packet_percpu_multicore_worker_alloc( function, queue); - if (!queue->worker) + if (!queue->worker) { + ptr_ring_cleanup(&queue->ring, NULL); return -ENOMEM; + } } else { INIT_WORK(&queue->work, function); } -- cgit v1.2.3-59-g8ed1b