wireguard-linux/drivers/crypto/ccree/cc_hash.c, branch jd/unified-crypt-queue

crypto: ccree - remove ancient TODO remarks

2020-03-12T12:00:16Z

Remove left over ancient and now misleading TODO remarks. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - use devm_kzalloc() for hash data

2020-02-22T01:25:46Z

As the lifetime of the hash data matches the lifetime of the driver, hash data can be allocated using the managed allocators. While at it, simplify cc_hash_free() by removing an unneeded check (hash_handle is always valid here). Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - use devm_k[mz]alloc() for AEAD data

2020-02-22T01:25:46Z

As the lifetime of the AEAD data matches the lifetime of the driver, AEAD data can be allocated using the managed allocators. While at it, simplify cc_aead_free() by removing an unneeded cast, and an unneeded check (aead_handle is always valid here). Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - improve kerneldoc in cc_hash.[ch]

2020-02-22T01:25:45Z

Miscellaneous improvements: - Start comment blocks with "/**" to enable kerneldoc, - Mark parameters using "@" instead of "\param", - Add missing function names to kerneldoc headers, - Add missing parameter descriptions. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - extract cc_init_copy_sram()

2020-02-22T01:25:45Z

Extract the copy to SRAM of the initial values for a hash algorithm into its own function, to improve readability and ease maintenance. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - use u32 for SRAM addresses

2020-02-22T01:25:44Z

SRAM addresses are small integer offsets into local SRAM. Currently they are stored using a mixture of cc_sram_addr_t (u64), u32, and dma_addr_t types. Settle on u32, and remove the cc_sram_addr_t typedefs. This allows to drop several casts. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - defer larval_digest_addr init until needed

2020-02-22T01:25:44Z

While the larval digest addresses are not always used in cc_get_plain_hmac_key() and cc_hash_digest(), they are always calculated. Defer their calculations to the points where needed. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - drop duplicated error message on SRAM exhaustion

2020-02-22T01:25:43Z

When no SRAM can be allocated, cc_sram_alloc() already prints an error message. Hence there is no need to duplicate this in all callers. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - swap SHA384 and SHA512 larval hashes at build time

2020-02-22T01:25:43Z

Due to the way the hardware works, every double word in the SHA384 and SHA512 larval hashes must be swapped. Currently this is done at run time, during driver initialization. However, this swapping can easily be done at build time. Treating each double word as two words has the benefit of changing the larval hashes' types from u64[] to u32[], like for all other hashes, and allows dropping the casts and size doublings when calling cc_set_sram_desc(). Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - remove unneeded casts

2020-02-22T01:25:43Z

Unneeded casts prevent the compiler from performing valuable checks. This is especially true for function pointers. Remove these casts, to prevent silently introducing bugs when a variable's type might be changed in the future. No change in generated code. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu