wireguard-linux/drivers/crypto/ccree/cc_pm.c, branch jd/unified-crypt-queue

crypto: ccree - make cc_pm_{suspend,resume}() static

2020-02-22T01:25:44Z

cc_pm_suspend() and cc_pm_resume() are not used outside drivers/crypto/ccree/cc_pm.c. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - remove cc_pm_is_dev_suspended() wrapper

2020-02-22T01:25:44Z

If CONFIG_PM=y, cc_pm_is_dev_suspended() is just a wrapper around pm_runtime_suspended(). If CONFIG_PM=n, cc_pm_is_dev_suspended() a dummy that behaves exactly the same as the dummy for pm_runtime_suspended(). Hence remove cc_pm_is_dev_suspended(), and call pm_runtime_suspended() directly. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - simplify Runtime PM handling

2020-02-22T01:25:44Z

Currently, a large part of the probe function runs before Runtime PM is enabled. As the driver manages the device's clock manually, this may work fine on some systems, but may break on platforms with a more complex power hierarchy. Fix this by moving the initialization of Runtime PM before the first register access (in cc_wait_for_reset_completion()), and putting the device to sleep only after the last access (in cc_set_ree_fips_status()). This allows to remove the pm_on flag, which was used to track manually if Runtime PM had been enabled or not. Remove the cc_pm_{init,go,fini}() wrappers, as they are called only once, and obscure operation. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - clean up clock handling

2020-02-22T01:25:43Z

Use devm_clk_get_optional() instead of devm_clk_get() and explicit optional clock handling. As clk_prepare_enable() and clk_disable_unprepare() handle optional clocks fine, the cc_clk_on() and cc_clk_off() wrappers can be removed. While at it, use the new "%pe" format specifier to print error codes. Signed-off-by: Geert Uytterhoeven Signed-off-by: Herbert Xu

crypto: ccree - make cc_pm_put_suspend() void

2020-01-22T08:21:10Z

cc_pm_put_suspend() return value was never checked and is not useful. Turn it into a void functions. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - fix PM race condition

2020-01-22T08:21:10Z

The PM code was racy, possibly causing the driver to submit requests to a powered down device. Fix the race and while at it simplify the PM code. Signed-off-by: Gilad Ben-Yossef Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init") Cc: stable@kernel.org # v4.20 Signed-off-by: Herbert Xu

crypto: ccree - fix pm wrongful error reporting

2020-01-22T08:21:10Z

pm_runtime_get_sync() can return 1 as a valid (none error) return code. Treat it as such. Signed-off-by: Gilad Ben-Yossef Cc: stable@vger.kernel.org # v4.19+ Signed-off-by: Herbert Xu

crypto: ccree - fix typo in comment

2020-01-22T08:21:09Z

Fixed a typo in a commnet. Signed-off-by: Hadar Gat Signed-off-by: Herbert Xu

crypto: ccree - fix typos in comments

2019-12-11T08:36:54Z

Fix some typos in code comments. Signed-off-by: Hadar Gat Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu

crypto: ccree - drop legacy ivgen support

2019-07-26T04:51:55Z

ccree had a mechanism for IV generation which was not compatible with the Linux seqiv or echainiv iv generator and was never used in any of the upstream versions so drop all the code implementing it. Signed-off-by: Gilad Ben-Yossef Signed-off-by: Herbert Xu