<feed xmlns='http://www.w3.org/2005/Atom'>
<title>wireguard-linux/drivers/crypto/ccree/cc_request_mgr.c, branch jd/unified-crypt-queue</title>
<subtitle>WireGuard for the Linux kernel</subtitle>
<id>https://git.zx2c4.com/wireguard-linux/atom/drivers/crypto/ccree/cc_request_mgr.c?h=jd%2Funified-crypt-queue</id>
<link rel='self' href='https://git.zx2c4.com/wireguard-linux/atom/drivers/crypto/ccree/cc_request_mgr.c?h=jd%2Funified-crypt-queue'/>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/'/>
<updated>2020-03-12T12:00:16Z</updated>
<entry>
<title>crypto: ccree - remove ancient TODO remarks</title>
<updated>2020-03-12T12:00:16Z</updated>
<author>
<name>Gilad Ben-Yossef</name>
<email>gilad@benyossef.com</email>
</author>
<published>2020-03-08T15:57:06Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=6429ccdd4f2d873db73ca60342669e160b0a7226'/>
<id>urn:sha1:6429ccdd4f2d873db73ca60342669e160b0a7226</id>
<content type='text'>
Remove left over ancient and now misleading TODO remarks.

Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - grammar s/not room/no room/</title>
<updated>2020-02-22T01:25:46Z</updated>
<author>
<name>Geert Uytterhoeven</name>
<email>geert+renesas@glider.be</email>
</author>
<published>2020-02-11T18:19:24Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=24b540f649a932a110b988c26165b8216e8d859e'/>
<id>urn:sha1:24b540f649a932a110b988c26165b8216e8d859e</id>
<content type='text'>
Fix grammar in a comment.

Signed-off-by: Geert Uytterhoeven &lt;geert+renesas@glider.be&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - improve kerneldoc in cc_request_mgr.[ch]</title>
<updated>2020-02-22T01:25:46Z</updated>
<author>
<name>Geert Uytterhoeven</name>
<email>geert+renesas@glider.be</email>
</author>
<published>2020-02-11T18:19:21Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=5c68361f5746b036d8aa55222f910a5a6fc86e8e'/>
<id>urn:sha1:5c68361f5746b036d8aa55222f910a5a6fc86e8e</id>
<content type='text'>
Miscellaneous improvements:
  - Start comment blocks with "/**" to enable kerneldoc,
  - Mark parameters using "@" instead of "\param",
  - Fix copied is_dout parameter of cc_send_request(),
  - Add missing function names to kerneldoc headers,
  - Add missing parameter descriptions.

Signed-off-by: Geert Uytterhoeven &lt;geert+renesas@glider.be&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - fix retry handling in cc_send_sync_request()</title>
<updated>2020-02-22T01:25:43Z</updated>
<author>
<name>Geert Uytterhoeven</name>
<email>geert+renesas@glider.be</email>
</author>
<published>2020-02-11T18:18:57Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=b83fd3e5ec284453561784491d877ceff950d1c6'/>
<id>urn:sha1:b83fd3e5ec284453561784491d877ceff950d1c6</id>
<content type='text'>
If cc_queues_status() indicates that the queue is full,
cc_send_sync_request() should loop and retry.

However, cc_queues_status() returns either 0 (for success), or -ENOSPC
(for queue full), while cc_send_sync_request() checks for real errors by
comparing with -EAGAIN.  Hence -ENOSPC is always considered a real
error, and the code never retries the operation.

Fix this by just removing the check, as cc_queues_status() never returns
any other error value than -ENOSPC.

Signed-off-by: Geert Uytterhoeven &lt;geert+renesas@glider.be&gt;
Acked-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - fix PM race condition</title>
<updated>2020-01-22T08:21:10Z</updated>
<author>
<name>Gilad Ben-Yossef</name>
<email>gilad@benyossef.com</email>
</author>
<published>2020-01-16T10:14:43Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=15fd2566bf54ee4d4781d8f170acfc9472a1541f'/>
<id>urn:sha1:15fd2566bf54ee4d4781d8f170acfc9472a1541f</id>
<content type='text'>
The PM code was racy, possibly causing the driver to submit
requests to a powered down device. Fix the race and while
at it simplify the PM code.

Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
Cc: stable@kernel.org # v4.20
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - cc_do_send_request() is void func</title>
<updated>2020-01-22T08:21:10Z</updated>
<author>
<name>Gilad Ben-Yossef</name>
<email>gilad@benyossef.com</email>
</author>
<published>2020-01-16T10:14:41Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=8b0c4366cb08d5064b882e82e31b025da8b36c87'/>
<id>urn:sha1:8b0c4366cb08d5064b882e82e31b025da8b36c87</id>
<content type='text'>
cc_do_send_request() cannot fail and always returns
-EINPROGRESS. Turn it into a void function and simplify
code.

Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - fix typos in error msgs</title>
<updated>2020-01-22T08:21:09Z</updated>
<author>
<name>Hadar Gat</name>
<email>hadar.gat@arm.com</email>
</author>
<published>2020-01-16T10:14:36Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=509f2885a2d216e1cfe7d995ce39ede120ddebc0'/>
<id>urn:sha1:509f2885a2d216e1cfe7d995ce39ede120ddebc0</id>
<content type='text'>
Fixed typos in ccree error msgs.

Signed-off-by: Hadar Gat &lt;hadar.gat@arm.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - fix backlog memory leak</title>
<updated>2019-12-11T08:36:55Z</updated>
<author>
<name>Gilad Ben-Yossef</name>
<email>gilad@benyossef.com</email>
</author>
<published>2019-11-27T08:49:08Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=4df2ef25b3b3618fd708ab484fe6239abd130fec'/>
<id>urn:sha1:4df2ef25b3b3618fd708ab484fe6239abd130fec</id>
<content type='text'>
Fix brown paper bag bug of not releasing backlog list item buffer
when backlog was consumed causing a memory leak when backlog is
used.

Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - fix typos in comments</title>
<updated>2019-12-11T08:36:54Z</updated>
<author>
<name>Hadar Gat</name>
<email>hadar.gat@arm.com</email>
</author>
<published>2019-11-27T08:49:06Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=e86eca4107ce067e6059fcc4544680ecbac4e80b'/>
<id>urn:sha1:e86eca4107ce067e6059fcc4544680ecbac4e80b</id>
<content type='text'>
Fix some typos in code comments.

Signed-off-by: Hadar Gat &lt;hadar.gat@arm.com&gt;
Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
<entry>
<title>crypto: ccree - drop legacy ivgen support</title>
<updated>2019-07-26T04:51:55Z</updated>
<author>
<name>Gilad Ben-Yossef</name>
<email>gilad@benyossef.com</email>
</author>
<published>2019-07-02T11:39:18Z</published>
<link rel='alternate' type='text/html' href='https://git.zx2c4.com/wireguard-linux/commit/?id=e6e6600c001c3aa3760aeb83dbd4630063e926ee'/>
<id>urn:sha1:e6e6600c001c3aa3760aeb83dbd4630063e926ee</id>
<content type='text'>
ccree had a mechanism for IV generation which was not compatible
with the Linux seqiv or echainiv iv generator and was never used
in any of the upstream versions so drop all the code implementing it.

Signed-off-by: Gilad Ben-Yossef &lt;gilad@benyossef.com&gt;
Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
</content>
</entry>
</feed>
