wireguard-linux/drivers/staging/sm750fb, branch stable

staging: sm750fb: fix mono image source stride mismatch in lynxfb_ops_imageblit()

2026-09-01T13:51:53Z

sm750_hw_imageblit() advances its monochrome source pointer by src_delta per scanline, and computes the correct rounded-up stride internally as: bytes_per_scan = (width + start_bit + 7) / 8; Its only caller, lynxfb_ops_imageblit(), instead passed src_delta as image->width >> 3. For widths not a multiple of 8 this under-counted the stride, so the source pointer fell further behind the real per-scanline layout on every line, corrupting the rendered image. Rather than just fixing the caller's calculation, remove src_delta as a parameter entirely and have sm750_hw_imageblit() advance by the bytes_per_scan it already computes for itself. There has only ever been one caller, and that caller was passing an out-of-sync derivative of the same width/start_bit values sm750_hw_imageblit() already has, so keeping stride as a separate parameter served no purpose beyond letting the two calculations drift apart, which is exactly what happened here. Rounding up, rather than down, is the direction consistent with the rest of the fbdev core: struct fb_image mono bitmap data (the same image->data this driver receives) is walked elsewhere with byte strides derived from a ceiling division of width by 8. The generic mono bit iterator in drivers/video/fbdev/core/fb_imageblit.h advances scanlines with "iter->data += BITS_TO_BYTES(iter->width)", and BITS_TO_BYTES() (include/linux/bitops.h) is a ceiling division. sm750_hw_imageblit()'s own "(width + start_bit + 7) / 8" is that same ceiling division with an added start_bit offset, so the caller's ">> 3" (floor) was the one calculation out of step with how this data layout is handled everywhere else. Found by code review of sm750_hw_imageblit()'s internal stride calculation against what its only caller was passing in, and confirmed with a clean -Werror build. I do not have this hardware, so this has not been exercised at runtime on real sm750 silicon. Fixes: 81dee67e215b2 ("staging: sm750fb: add sm750 to staging") Cc: stable@vger.kernel.org Reviewed-by: Dan Carpenter Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260901113031.161610-1-meatuni001@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: Remove unused function sm750_enable_dma

2026-07-28T07:24:50Z

The function sm750_enable_dma is defined in ddk750_power.c and declared in ddk750_power.h, but it is not called anywhere in the driver. Remove the unused definition and declaration. This addresses the first task in the drivers/staging/sm750fb/TODO list: "- refine the code and remove unused code". Signed-off-by: Mohit Mishra Link: https://patch.msgid.link/20260725090750.113598-2-mishraloopmohit@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: rename CamelCase parameters in sm750_accel.h

2026-07-28T07:24:01Z

The prototypes and kernel-doc comments for sm750_hw_copyarea() and sm750_hw_imageblit() still use the old CamelCase parameter names, while the function definitions in sm750_accel.c already use snake_case. Rename the header parameters to match the definitions. Fixes 10 checkpatch "Avoid CamelCase" checks. No functional change. Signed-off-by: Gabriel Changamire Link: https://patch.msgid.link/20260719064601.12223-1-gaberashawn@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: Clean up whitespace and comment spacing in headers

2026-07-28T07:23:51Z

Clean up minor formatting inconsistencies in sm750.h and sm750_accel.h: - Remove a redundant consecutive blank line in sm750.h. - Add missing spaces in comment blocks in sm750.h and sm750_accel.h. - Align DE_SOURCE_X_K1_MONO_MASK macro definition in sm750_accel.h with spaces instead of tabs to match surrounding macros. Signed-off-by: Mohit Mishra Link: https://patch.msgid.link/20260722175817.213235-2-mishraloopmohit@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: remove unused set_all_eng_off field

2026-07-17T12:19:40Z

The set_all_eng_off field is only initialized to 0 and is never set by any caller. Remove the unused field together with the dead cleanup path guarded by it. No functional change intended. Signed-off-by: Hungyu Lin Link: https://patch.msgid.link/20260716044613.2659-1-dennylin0707@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: rename pvReg to mmio

2026-07-07T09:20:05Z

Rename the Hungarian-notation pvReg field to mmio, which describes what it is (memory-mapped I/O) rather than what type it is (pointer to void). This is a purely mechanical change with no functional difference. Signed-off-by: Jad Keskes Link: https://patch.msgid.link/20260619091332.622116-1-inasj268@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: Add missing Kconfig dependency

2026-07-07T09:18:37Z

The sm750 frame buffer driver depends on FB_IOMEM_FOPS, but its Kconfig somehow misses it. Fix it by making FB_SM750 select FB_IOMEM_FOPS, as other frame buffer drivers do. Fixes: dc0ad215e5d8 ("staging/sm750fb: Initialize fb_ops with fbdev macros") Signed-off-by: Rong Zhang Link: https://patch.msgid.link/20260603-sm750-fb-iomem-kconfig-v1-1-7f6a3046cce2@rong.moe Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: remove duplicate init_status structure

2026-07-07T09:18:33Z

struct init_status duplicates struct initchip_param and is only used within the sm750fb driver. Replace the remaining users of struct init_status with struct initchip_param, remove the duplicate structure and eliminate the unnecessary cast in hw_sm750_inithw(). No functional change intended. Signed-off-by: Hungyu Lin Reviewed-by: Dan Carpenter Link: https://patch.msgid.link/20260530222432.4303-1-dennylin0707@gmail.com Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: remove unused struct fields

2026-07-07T09:18:21Z

Remove `void *priv` pointer field in following struct definitions: - `struct lynxfb_crtc` - `struct lynxfb_output` Verified that no other code references them. No functional changes. Signed-off-by: Ahmet Sezgin Duran Link: https://patch.msgid.link/20260525085808.171974-4-ahmet@sezginduran.net Signed-off-by: Greg Kroah-Hartman

staging: sm750fb: remove unnecessary initializations

2026-07-07T09:18:14Z

Remove two instances of `ret = 0` initializations since the variable is overridden unconditionally before being used. Signed-off-by: Ahmet Sezgin Duran Link: https://patch.msgid.link/20260525085808.171974-3-ahmet@sezginduran.net Signed-off-by: Greg Kroah-Hartman