wireguard-linux/net/bridge/br_fdb.c, branch jd/unified-crypt-queue

net: bridge: fdb: eliminate extra port state tests from fast-path

2019-11-04T19:15:27Z

When commit df1c0b8468b3 ("[BRIDGE]: Packets leaking out of disabled/blocked ports.") introduced the port state tests in br_fdb_update() it was to avoid learning/refreshing from STP BPDUs, it was also used to avoid learning/refreshing from user-space with NTF_USE. Those two tests are done for every packet entering the bridge if it's learning, but for the fast-path we already have them checked in br_handle_frame() and is unnecessary to do it again. Thus push the checks to the unlikely cases and drop them from br_fdb_update(), the new nbp_state_should_learn() helper is used to determine if the port state allows br_fdb_update() to be called. The two places which need to do it manually are: - user-space add call with NTF_USE set - link-local packet learning done in __br_handle_local_finish() Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: restore unlikely() when taking over externally added entries

2019-11-01T17:32:43Z

Taking over hw-learned entries is not a likely scenario so restore the unlikely() use for the case of SW taking over externally learned entries. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: avoid two atomic bitops in br_fdb_external_learn_add()

2019-11-01T17:32:43Z

If we setup the fdb flags prior to calling fdb_create() we can avoid two atomic bitops when learning a new entry. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: br_fdb_update can take flags directly

2019-11-01T17:32:43Z

If we modify br_fdb_update() to take flags directly we can get rid of one test and one atomic bitop in the learning path. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: set flags directly in fdb_create

2019-10-30T01:12:49Z

No need to have separate arguments for each flag, just set the flags to whatever was passed to fdb_create() before the fdb is published. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: convert offloaded to use bitops

2019-10-30T01:12:49Z

Convert the offloaded field to a flag and use bitops. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: convert added_by_external_learn to use bitops

2019-10-30T01:12:49Z

Convert the added_by_external_learn field to a flag and use bitops. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: convert added_by_user to bitops

2019-10-30T01:12:49Z

Straight-forward convert of the added_by_user field to bitops. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: convert is_sticky to bitops

2019-10-30T01:12:49Z

Straight-forward convert of the is_sticky field to bitops. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller

net: bridge: fdb: convert is_static to bitops

2019-10-30T01:12:49Z

Convert the is_static to bitops, make use of the combined test_and_set/clear_bit to simplify expressions in fdb_add_entry. Signed-off-by: Nikolay Aleksandrov Signed-off-by: David S. Miller