diff options
| author |   Kent Overstreet <kent.overstreet@linux.dev> | 2024-06-17 09:51:01 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-06-19 18:27:24 -0400 |
| commit | 1ba44217f8258f92c56644ca4fad4462f1941e33 (patch) | |
| tree | b06a4195a19403ce0387090bb8fb7bdbdd467eb0 | |
| parent | bcachefs: Fix early init error path in journal code (diff) | |
| download | wireguard-linux-1ba44217f8258f92c56644ca4fad4462f1941e33.tar.xz wireguard-linux-1ba44217f8258f92c56644ca4fad4462f1941e33.zip | |
bcachefs: delete_dead_snapshots() doesn't need to go RW
We've been moving away from going RW lazily; if we want to go RW we do
that in set_may_go_rw(), and if we didn't go RW we don't need to delete
dead snapshots.
Reported-by: syzbot+4366624c0b5aac4906cf@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to '')
| -rw-r--r-- | fs/bcachefs/snapshot.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/fs/bcachefs/snapshot.c b/fs/bcachefs/snapshot.c index 51918acfd726..961b5f56358c 100644 --- a/fs/bcachefs/snapshot.c +++ b/fs/bcachefs/snapshot.c @@ -1565,13 +1565,6 @@ int bch2_delete_dead_snapshots(struct bch_fs *c) if (!test_and_clear_bit(BCH_FS_need_delete_dead_snapshots, &c->flags)) return 0; - if (!test_bit(BCH_FS_started, &c->flags)) { - ret = bch2_fs_read_write_early(c); - bch_err_msg(c, ret, "deleting dead snapshots: error going rw"); - if (ret) - return ret; - } - trans = bch2_trans_get(c); /* |