diff options
| author |   Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> | 2025-01-07 14:44:53 +0900 |
|---|---|---|
| committer |   Viresh Kumar <viresh.kumar@linaro.org> | 2025-01-07 11:37:52 +0530 |
| commit | 1d38eb7f7b26261a0b642f6e0923269c7c000a97 (patch) | |
| tree | e5ec228a3f2fc1132d0681d18e7be3a9eb103174 | |
| parent | OPP: fix dev_pm_opp_find_bw_*() when bandwidth table not initialized (diff) | |
| download | wireguard-linux-1d38eb7f7b26261a0b642f6e0923269c7c000a97.tar.xz wireguard-linux-1d38eb7f7b26261a0b642f6e0923269c7c000a97.zip | |
OPP: OF: Fix an OF node leak in _opp_add_static_v2()
_opp_add_static_v2() leaks the obtained OF node reference when
_of_opp_alloc_required_opps() fails. Add an of_node_put() call in the
error path.
Fixes: 3466ea2cd6b6 ("OPP: Don't drop opp->np reference while it is still in use")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/opp/of.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index fd5ed2858258..a24f76f5fd01 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -926,7 +926,7 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table, ret = _of_opp_alloc_required_opps(opp_table, new_opp); if (ret) - goto free_opp; + goto put_node; if (!of_property_read_u32(np, "clock-latency-ns", &val)) new_opp->clock_latency_ns = val; @@ -976,6 +976,8 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table, free_required_opps: _of_opp_free_required_opps(opp_table, new_opp); +put_node: + of_node_put(np); free_opp: _opp_free(new_opp); |