diff options
| author |   Daniel Baluta <daniel.baluta@nxp.com> | 2025-01-27 10:34:22 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2025-01-27 13:35:35 +0000 |
| commit | 3ff53862c322aa7bb115d84348d5a641dc905d87 (patch) | |
| tree | e8a595297b2bf2183e1e7393358b220d6ce5bb40 | |
| parent | firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAP (diff) | |
| download | wireguard-linux-3ff53862c322aa7bb115d84348d5a641dc905d87.tar.xz wireguard-linux-3ff53862c322aa7bb115d84348d5a641dc905d87.zip | |
ASoC: amd: acp: Fix possible deadlock
On error path, function acp_i2s_set_tdm_slot returns without releasing
the lock and this could result in potential deadlocks in the future.
Error reported by sparse:
sound/soc/amd/acp/acp-i2s.c:95:12: error: context imbalance in
'acp_i2s_set_tdm_slot' - different lock contexts for basic block
Fixes: cd60dec8994c ("ASoC: amd: acp: Refactor TDM slots selction based on acp revision id")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250127083422.20406-1-daniel.baluta@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | sound/soc/amd/acp/acp-i2s.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c index 1f59ee248771..89e99ed4275a 100644 --- a/sound/soc/amd/acp/acp-i2s.c +++ b/sound/soc/amd/acp/acp-i2s.c @@ -181,6 +181,7 @@ static int acp_i2s_set_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask, u32 rx_mas break; default: dev_err(dev, "Unknown chip revision %d\n", chip->acp_rev); + spin_unlock_irq(&adata->acp_lock); return -EINVAL; } } |