diff options
| author |   Nikolay Aleksandrov <razor@blackwall.org> | 2024-06-09 13:36:54 +0300 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2024-06-12 18:24:24 -0700 |
| commit | 546ceb1dfdac866648ec959cbc71d9525bd73462 (patch) | |
| tree | 1615fa29d71e6178b5e203beccf93a891c54416a | |
| parent | net: bridge: mst: pass vlan group directly to br_mst_vlan_set_state (diff) | |
| download | wireguard-linux-546ceb1dfdac866648ec959cbc71d9525bd73462.tar.xz wireguard-linux-546ceb1dfdac866648ec959cbc71d9525bd73462.zip | |
net: bridge: mst: fix suspicious rcu usage in br_mst_set_state
I converted br_mst_set_state to RCU to avoid a vlan use-after-free
but forgot to change the vlan group dereference helper. Switch to vlan
group RCU deref helper to fix the suspicious rcu usage warning.
Fixes: 3a7c1661ae13 ("net: bridge: mst: fix vlan use-after-free")
Reported-by: syzbot+9bbe2de1bc9d470eb5fe@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=9bbe2de1bc9d470eb5fe
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20240609103654.914987-3-razor@blackwall.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | net/bridge/br_mst.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_mst.c b/net/bridge/br_mst.c index 1de72816b0fb..1820f09ff59c 100644 --- a/net/bridge/br_mst.c +++ b/net/bridge/br_mst.c @@ -102,7 +102,7 @@ int br_mst_set_state(struct net_bridge_port *p, u16 msti, u8 state, int err = 0; rcu_read_lock(); - vg = nbp_vlan_group(p); + vg = nbp_vlan_group_rcu(p); if (!vg) goto out; |