diff options
| author |   David Rientjes <rientjes@google.com> | 2025-01-09 16:24:33 -0800 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2025-01-13 14:10:23 +0100 |
| commit | 8061b9f5e111a3012f8b691e5b75dd81eafbb793 (patch) | |
| tree | cbef07c729fbf0e675999a165a039fa71961a91b | |
| parent | sched/fair: Encapsulate set custom slice in a __setparam_fair() function (diff) | |
| download | wireguard-linux-8061b9f5e111a3012f8b691e5b75dd81eafbb793.tar.xz wireguard-linux-8061b9f5e111a3012f8b691e5b75dd81eafbb793.zip | |
sched/debug: Change need_resched warnings to pr_err
need_resched warnings, if enabled, are treated as WARNINGs. If
kernel.panic_on_warn is enabled, then this causes a kernel panic.
It's highly unlikely that a panic is desired for these warnings, only a
stack trace is normally required to debug and resolve.
Thus, switch need_resched warnings to simply be a printk with an
associated stack trace so they are no longer in scope for panic_on_warn.
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Acked-by: Josh Don <joshdon@google.com>
Link: https://lkml.kernel.org/r/e8d52023-5291-26bd-5299-8bb9eb604929@google.com
Diffstat (limited to '')
| -rw-r--r-- | kernel/sched/debug.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 5e8e84a2bcb1..fd7e85220715 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -1292,8 +1292,10 @@ void resched_latency_warn(int cpu, u64 latency) { static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1); - WARN(__ratelimit(&latency_check_ratelimit), - "sched: CPU %d need_resched set for > %llu ns (%d ticks) " - "without schedule\n", - cpu, latency, cpu_rq(cpu)->ticks_without_resched); + if (likely(!__ratelimit(&latency_check_ratelimit))) + return; + + pr_err("sched: CPU %d need_resched set for > %llu ns (%d ticks) without schedule\n", + cpu, latency, cpu_rq(cpu)->ticks_without_resched); + dump_stack(); } |