diff options
| author |   Dave Penkler <dpenkler@gmail.com> | 2025-01-16 12:00:14 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-01-16 13:23:35 +0100 |
| commit | 9ed145e64f0af9a22e95f79940c540affbd939e2 (patch) | |
| tree | a5d79983b5402e35c7ec306186f3ddc36d957d4c | |
| parent | staging: gpib: fix prefixing 0x with decimal output (diff) | |
| download | wireguard-linux-9ed145e64f0af9a22e95f79940c540affbd939e2.tar.xz wireguard-linux-9ed145e64f0af9a22e95f79940c540affbd939e2.zip | |
staging: gpib: Fix inadvertent negative shift
During the initial checkpatch cleanup, when removing blanks
after open parentheses, a minus sign in the argument of a shift
operation was deleted by mistake. This transformed a pre-decrement
operation into a negation.
The result of a negative shift is undefined and a warning was
signalled by sparse.
Restore the pre-decrement operation.
Fixes: 6c52d5e3cde2 ("staging: gpib: Add common include files for GPIB drivers")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250116110014.15577-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/staging/gpib/include/amcc5920.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/gpib/include/amcc5920.h b/drivers/staging/gpib/include/amcc5920.h index 766b3799223f..7a88bd282feb 100644 --- a/drivers/staging/gpib/include/amcc5920.h +++ b/drivers/staging/gpib/include/amcc5920.h @@ -22,7 +22,7 @@ static const int bits_per_region = 8; static inline uint32_t amcc_wait_state_bits(unsigned int region, unsigned int num_wait_states) { - return (num_wait_states & 0x7) << (-region * bits_per_region); + return (num_wait_states & 0x7) << (--region * bits_per_region); }; enum amcc_prefetch_bits { |