aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorFurong Xu <0x1207@gmail.com>2025-01-17 14:28:05 +0800
committerJakub Kicinski <kuba@kernel.org>2025-01-20 12:03:27 -0800
commitba5f78505fb4e3feb73d8e5249a13b3244dac4d9 (patch)
tree3ea1b150ab6ced0e152fe68416593e0efefcc8d8
parentnet: mii: Fix the Speed display when the network cable is not connected (diff)
downloadwireguard-linux-ba5f78505fb4e3feb73d8e5249a13b3244dac4d9.tar.xz
wireguard-linux-ba5f78505fb4e3feb73d8e5249a13b3244dac4d9.zip
net: stmmac: Drop redundant skb_mark_for_recycle() for SKB frags
After commit df542f669307 ("net: stmmac: Switch to zero-copy in non-XDP RX path"), SKBs are always marked for recycle, it is redundant to mark SKBs more than once when new frags are appended. Signed-off-by: Furong Xu <0x1207@gmail.com> Link: https://patch.msgid.link/20250117062805.192393-1-0x1207@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
-rw-r--r--drivers/net/ethernet/stmicro/stmmac/stmmac_main.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index d99ad77a8005..edbf8994455d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -5644,9 +5644,6 @@ read_again:
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
buf->page, buf->page_offset, buf1_len,
priv->dma_conf.dma_buf_sz);
-
- /* Data payload appended into SKB */
- skb_mark_for_recycle(skb);
buf->page = NULL;
}
@@ -5656,9 +5653,6 @@ read_again:
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
buf->sec_page, 0, buf2_len,
priv->dma_conf.dma_buf_sz);
-
- /* Data payload appended into SKB */
- skb_mark_for_recycle(skb);
buf->sec_page = NULL;
}