aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2023-11-23 22:16:59 +0100
committerMathieu Poirier <mathieu.poirier@linaro.org>2023-11-30 09:39:29 -0700
commitbddae3e7ae70586b3805fdbce193760f13b4d73e (patch)
tree69d6d8b36a36c1971690b34b3b1c6d828f7b4aaf
parentarm64: dts: imx8mp: Add reserve-memory nodes for DSP (diff)
downloadwireguard-linux-bddae3e7ae70586b3805fdbce193760f13b4d73e.tar.xz
wireguard-linux-bddae3e7ae70586b3805fdbce193760f13b4d73e.zip
remoteproc: k3-dsp: Suppress duplicate error message in .remove()
When the remove callback returns non-zero, the driver core emits an error message about the error value being ignored. As the driver already emits an error message already, return zero. This has no effect apart from suppressing the core's message. The platform device gets unbound irrespective of the return value. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231123211657.518181-6-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Diffstat (limited to '')
-rw-r--r--drivers/remoteproc/ti_k3_dsp_remoteproc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
index ef8415a7cd54..40a5fd8763fa 100644
--- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
+++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
@@ -835,8 +835,9 @@ static int k3_dsp_rproc_remove(struct platform_device *pdev)
if (rproc->state == RPROC_ATTACHED) {
ret = rproc_detach(rproc);
if (ret) {
+ /* Note this error path leaks resources */
dev_err(dev, "failed to detach proc, ret = %d\n", ret);
- return ret;
+ return 0;
}
}