diff options
| author |   James Bottomley <James.Bottomley@HansenPartnership.com> | 2025-01-06 18:35:20 -0800 |
|---|---|---|
| committer |   Ard Biesheuvel <ardb@kernel.org> | 2025-01-09 15:25:14 +0100 |
| commit | c57b6e1d8a5c133dd5f6293de262701a55d11335 (patch) | |
| tree | 297841464935b9b836b9979227c265200a14c873 | |
| parent | Linux 6.13-rc3 (diff) | |
| download | wireguard-linux-c57b6e1d8a5c133dd5f6293de262701a55d11335.tar.xz wireguard-linux-c57b6e1d8a5c133dd5f6293de262701a55d11335.zip | |
efivarfs: remove unused efi_variable.Attributes and efivar_entry.kobj
These fields look to be remnants of older code: Attributes was likely
meant to stash the variable attributes, but doesn't because we always
read them from the variable store and kobj was likely left over from
an older iteration of code where we manually created the objects
instead of using a filesystem.
[ ardb: these fields were used by the sysfs based 'efivars' precursor to
efivarfs, which was removed in commit 0f5b2c69a4cb ("efi: vars:
Remove deprecated 'efivars' sysfs interface") ]
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | fs/efivarfs/internal.h | 2 | ||||
| -rw-r--r-- | fs/efivarfs/super.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/fs/efivarfs/internal.h b/fs/efivarfs/internal.h index 74f0602a9e01..64d15d1bb6bf 100644 --- a/fs/efivarfs/internal.h +++ b/fs/efivarfs/internal.h @@ -24,13 +24,11 @@ struct efivarfs_fs_info { struct efi_variable { efi_char16_t VariableName[EFI_VAR_NAME_LEN/sizeof(efi_char16_t)]; efi_guid_t VendorGuid; - __u32 Attributes; }; struct efivar_entry { struct efi_variable var; struct list_head list; - struct kobject kobj; }; int efivar_init(int (*func)(efi_char16_t *, efi_guid_t, unsigned long, void *, diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c index beba15673be8..d3c8528274aa 100644 --- a/fs/efivarfs/super.c +++ b/fs/efivarfs/super.c @@ -245,7 +245,7 @@ static int efivarfs_callback(efi_char16_t *name16, efi_guid_t vendor, inode_lock(inode); inode->i_private = entry; - i_size_write(inode, size + sizeof(entry->var.Attributes)); + i_size_write(inode, size + sizeof(__u32)); /* attributes + data */ inode_unlock(inode); d_add(dentry, inode); |