aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorMohsin Bashir <mohsin.bashr@gmail.com>2025-05-02 19:01:45 -0700
committerPaolo Abeni <pabeni@redhat.com>2025-05-06 11:07:36 +0200
commitfbaeb7b0f0ffb660bcc91dd5f96eaf8d99721656 (patch)
tree02b1d3c92ee1fc1d648831957272cb5673488823
parentselftests: net: exit cleanly on SIGTERM / timeout (diff)
downloadwireguard-linux-fbaeb7b0f0ffb660bcc91dd5f96eaf8d99721656.tar.xz
wireguard-linux-fbaeb7b0f0ffb660bcc91dd5f96eaf8d99721656.zip
eth: fbnic: fix `tx_dropped` counting
Fix the tracking of rtnl_link_stats.tx_dropped. The counter `tmi.drop.frames` is being double counted whereas, the counter `tti.cm_drop.frames` is being skipped. Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats") Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com> Reviewed-by: Joe Damato <jdamato@fastly.com> Link: https://patch.msgid.link/20250503020145.1868252-1-mohsin.bashr@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to '')
-rw-r--r--drivers/net/ethernet/meta/fbnic/fbnic_netdev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
index d699f58dda21..f994cbf1857d 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
@@ -425,9 +425,9 @@ static void fbnic_get_stats64(struct net_device *dev,
/* Record drops from Tx HW Datapath */
tx_dropped += fbd->hw_stats.tmi.drop.frames.value +
+ fbd->hw_stats.tti.cm_drop.frames.value +
fbd->hw_stats.tti.frame_drop.frames.value +
- fbd->hw_stats.tti.tbi_drop.frames.value +
- fbd->hw_stats.tmi.drop.frames.value;
+ fbd->hw_stats.tti.tbi_drop.frames.value;
for (i = 0; i < fbn->num_tx_queues; i++) {
struct fbnic_ring *txr = fbn->tx[i];