diff options
| author |   Andrea Righi <arighi@nvidia.com> | 2025-03-03 18:51:59 +0100 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2025-03-03 07:55:48 -1000 |
| commit | 9360dfe4cbd62ff1eb8217b815964931523b75b3 (patch) | |
| tree | 02d5452f2b0b802bc740957174f43c9d2914e90c | |
| parent | sched_ext: Fix pick_task_scx() picking non-queued tasks when it's called without balance() (diff) | |
| download | wireguard-linux-9360dfe4cbd62ff1eb8217b815964931523b75b3.tar.xz wireguard-linux-9360dfe4cbd62ff1eb8217b815964931523b75b3.zip | |
sched_ext: Validate prev_cpu in scx_bpf_select_cpu_dfl()
If a BPF scheduler provides an invalid CPU (outside the nr_cpu_ids
range) as prev_cpu to scx_bpf_select_cpu_dfl() it can cause a kernel
crash.
To prevent this, validate prev_cpu in scx_bpf_select_cpu_dfl() and
trigger an scx error if an invalid CPU is specified.
Fixes: f0e1a0643a59b ("sched_ext: Implement BPF extensible scheduler class")
Cc: stable@vger.kernel.org # v6.12+
Signed-off-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | kernel/sched/ext.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 0f1da199cfc7..7b9dfee858e7 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -6422,6 +6422,9 @@ static bool check_builtin_idle_enabled(void) __bpf_kfunc s32 scx_bpf_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, bool *is_idle) { + if (!ops_cpu_valid(prev_cpu, NULL)) + goto prev_cpu; + if (!check_builtin_idle_enabled()) goto prev_cpu; |