diff options
| author |   Daniel Thompson <daniel.thompson@linaro.org> | 2024-02-20 15:35:24 +0000 |
|---|---|---|
| committer |   Lee Jones <lee@kernel.org> | 2024-03-07 09:03:29 +0000 |
| commit | 0285e9efaee8276305db5c52a59baf84e9731556 (patch) | |
| tree | 7cdc5e5f7328ebcf7e9e4c80fc89763a9fe034dc | |
| parent | backlight: lm3630a: Use backlight_get_brightness helper in update_status (diff) | |
| download | wireguard-linux-0285e9efaee8276305db5c52a59baf84e9731556.tar.xz wireguard-linux-0285e9efaee8276305db5c52a59baf84e9731556.zip | |
backlight: da9052: Fully initialize backlight_properties during probe
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes: 6ede3d832aaa ("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220153532.76613-2-daniel.thompson@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/video/backlight/da9052_bl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c index 1cdc8543310b..b8ff7046510e 100644 --- a/drivers/video/backlight/da9052_bl.c +++ b/drivers/video/backlight/da9052_bl.c @@ -117,6 +117,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) wleds->led_reg = platform_get_device_id(pdev)->driver_data; wleds->state = DA9052_WLEDS_OFF; + memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.max_brightness = DA9052_MAX_BRIGHTNESS; |