diff options
| author |   Christoph Hellwig <hch@lst.de> | 2025-01-16 07:01:41 +0100 |
|---|---|---|
| committer |   Carlos Maiolino <cem@kernel.org> | 2025-01-16 10:19:59 +0100 |
| commit | 07eae0fa67ca4bbb199ad85645e0f9dfaef931cd (patch) | |
| tree | a91dceb852e028253fd45b4aff5efbff37e64d15 | |
| parent | xfs: add a b_iodone callback to struct xfs_buf (diff) | |
| download | wireguard-linux-07eae0fa67ca4bbb199ad85645e0f9dfaef931cd.tar.xz wireguard-linux-07eae0fa67ca4bbb199ad85645e0f9dfaef931cd.zip | |
xfs: check for dead buffers in xfs_buf_find_insert
Commit 32dd4f9c506b ("xfs: remove a superflous hash lookup when inserting
new buffers") converted xfs_buf_find_insert to use
rhashtable_lookup_get_insert_fast and thus an operation that returns the
existing buffer when an insert would duplicate the hash key. But this
code path misses the check for a buffer with a reference count of zero,
which could lead to reusing an about to be freed buffer. Fix this by
using the same atomic_inc_not_zero pattern as xfs_buf_insert.
Fixes: 32dd4f9c506b ("xfs: remove a superflous hash lookup when inserting new buffers")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Cc: stable@vger.kernel.org # v6.0
Signed-off-by: Carlos Maiolino <cem@kernel.org>
| -rw-r--r-- | fs/xfs/xfs_buf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index d9636bff16ce..183428fbc607 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -655,9 +655,8 @@ xfs_buf_find_insert( spin_unlock(&bch->bc_lock); goto out_free_buf; } - if (bp) { + if (bp && atomic_inc_not_zero(&bp->b_hold)) { /* found an existing buffer */ - atomic_inc(&bp->b_hold); spin_unlock(&bch->bc_lock); error = xfs_buf_find_lock(bp, flags); if (error) |