diff options
| author |   Maximilian Immanuel Brandtner <maxbr@linux.ibm.com> | 2025-03-24 15:42:46 +0100 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2025-04-18 10:08:11 -0400 |
| commit | 5326ab737a47278dbd16ed3ee7380b26c7056ddd (patch) | |
| tree | 36dd46a963cece09645e3a34b119318b8e892412 | |
| parent | virtio_console: fix missing byte order handling for cols and rows (diff) | |
| download | wireguard-linux-5326ab737a47278dbd16ed3ee7380b26c7056ddd.tar.xz wireguard-linux-5326ab737a47278dbd16ed3ee7380b26c7056ddd.zip | |
virtio_console: fix order of fields cols and rows
According to section 5.3.6.2 (Multiport Device Operation) of the virtio
spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE
is followed by a virtio_console_resize struct containing cols then rows.
The kernel implements this the wrong way around (rows then cols) resulting
in the two values being swapped.
Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | drivers/char/virtio_console.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 216c5115637d..088182e54deb 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1576,8 +1576,8 @@ static void handle_control_message(struct virtio_device *vdev, break; case VIRTIO_CONSOLE_RESIZE: { struct { - __virtio16 rows; __virtio16 cols; + __virtio16 rows; } size; if (!is_console_port(port)) |